fix: support revalidateTag SWR in 'use cache' handler #3180
+1,198
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0.04%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
added
the
test latest and canary
pieh
force-pushed
the
fix/update-use-cache-handler
branch
from
8e49bbe to
dd90408
Compare
pieh
commented
Oct 16, 2025
| @@ -1,4 +1,4 @@ | |||
| import { unstable_cacheLife as cacheLife, unstable_cacheTag as cacheTag } from 'next/cache' | |||
| import { cacheLife, cacheTag } from '../../../../../next-cache' | |||
There was a problem hiding this comment.
This and other changes like that are not directly related to SWR revalidateTag. Instead it is because cacheLife is no longer exported as unstable_cacheLife - see vercel/next.js#84877 and this is just adjustment to make this fixture before/after this change
pieh
commented
Oct 16, 2025
Comment on lines
+5
to
+12
| export const cacheLife: any = | ||
| 'cacheLife' in NextCache | ||
| ? NextCache.cacheLife | ||
| : 'unstable_cacheLife' in NextCache | ||
| ? NextCache.unstable_cacheLife | ||
| : () => { | ||
| throw new Error('both unstable_cacheLife and cacheLife are missing from next/cache') | ||
| } |
There was a problem hiding this comment.
This was changed in vercel/next.js#84877
The cacheTag handling is just future proofing (it's still unstable_cacheTag as of now)
There was a problem hiding this comment.
cacheTag was also updated now (in vercel/next.js#84880 )
pieh
commented
Oct 16, 2025
Comment on lines
+545
to
+547
| env: { | ||
| NX_ISOLATE_PLUGINS: 'false', | ||
| }, |
There was a problem hiding this comment.
I'm not quite sure here, but without it we were hitting error described in nrwl/nx#27040 and this was suggested workaround and seems to work. While the issue was closed with a fix, it seems like it doesn't handle whatever happens in next@canary now
pieh
force-pushed
the
fix/update-use-cache-handler
branch
3 times, most recently
from
8707d32 to
981a652
Compare
pieh
changed the title
pieh
force-pushed
the
fix/update-use-cache-handler
branch
from
2029831 to
c8a4280
Compare
pieh
force-pushed
the
fix/update-use-cache-handler
branch
from
c8a4280 to
f7942b8
Compare
mrstork
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
revalidateTagSWR profiles foruse cachehandler. This is follow up to #3173 which added support for regular cache handler