chore: warn for incorrect _redirects file #1078
Conversation
|
✔️ Deploy Preview for netlify-plugin-nextjs-nx-monorepo-demo ready! 🔨 Explore the source changes: e23850a 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-nx-monorepo-demo/deploys/61eeb827fca6e6000781bb1f 😎 Browse the preview: https://deploy-preview-1078--netlify-plugin-nextjs-nx-monorepo-demo.netlify.app/ |
|
✔️ Deploy Preview for netlify-plugin-nextjs-static-root-demo ready! 🔨 Explore the source changes: e23850a 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-static-root-demo/deploys/61eeb827db0f0b00070a413a 😎 Browse the preview: https://deploy-preview-1078--netlify-plugin-nextjs-static-root-demo.netlify.app |
|
✔️ Deploy Preview for netlify-plugin-nextjs-demo ready! 🔨 Explore the source changes: e23850a 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-demo/deploys/61eeb8271c36a80007274538 😎 Browse the preview: https://deploy-preview-1078--netlify-plugin-nextjs-demo.netlify.app |
github-actions
bot
added
the
type: chore
|
✔️ Deploy Preview for netlify-plugin-nextjs-export-demo ready! 🔨 Explore the source changes: e23850a 🔍 Inspect the deploy log: https://app.netlify.com/sites/netlify-plugin-nextjs-export-demo/deploys/61eeb827bf30bf00085b5b41 😎 Browse the preview: https://deploy-preview-1078--netlify-plugin-nextjs-export-demo.netlify.app |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| if (existsSync(join(appDir, '_redirects'))) { | ||
| console.log( | ||
| yellowBright( | ||
| `You have a "_redirects" file in your root directory, which is not deployed and will be ignored. If you want it to be used, please move it into "public".`, |
ascorbic
force-pushed
the
mk/warn-redirects
branch
from
3d43d3d to
d27b539
Compare
ascorbic
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
| @@ -187,4 +187,14 @@ export const warnForProblematicUserRewrites = ({ | |||
| `), | |||
| ) | |||
| } | |||
|
|
|||
| export const warnForRootRedirects = ({ appDir }: { appDir: string }) => { | |||
There was a problem hiding this comment.
| export const warnForRootRedirects = ({ appDir }: { appDir: string }) => { | |
| export const warnForRootRedirects = ({ appDir }: { appDir: string }): void => { |
Summary
Adds a warning for
_redirectsfiles in the site root. We used to silently add these to the user's redirects, but we now follow the documented behaviour, which is that the files should go in the publish dir not site root. #1130 adds this to the docs, and the CLI warns about it too, but this adds Next.js-specific logs, with instructions on where it needs to go.Test plan
_redirectsfile to the root of a demo siteRelevant links (GitHub issues, Notion docs, etc.) or a picture of cute animal
Issue that shows the problem: #1008
Standard checks:
🧪 Once merged, make sure to update the version if needed and that it was published correctly.