Skip to content

Conversation

DriesSchaumont
Copy link
Member

@DriesSchaumont DriesSchaumont commented Oct 26, 2023

Changelog

  • Move the nextflow workflows to src/
  • Move the scripts that were used to generate the test resources to the resources_test_scripts folder in the root of the project and update them to point to the correct folder for the workflows
  • Update the CI

Issue ticket number and link

Closes #600 (Replace xxxx with the GitHub issue number)

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributor's guide

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI tests succeed!

@DriesSchaumont DriesSchaumont linked an issue Oct 26, 2023 that may be closed by this pull request
@DriesSchaumont DriesSchaumont marked this pull request as ready for review October 27, 2023 07:45
@DriesSchaumont
Copy link
Member Author

Integration tests here: https://github.com/openpipelines-bio/openpipeline/actions/runs/6663467458/job/18111866705
Timeout on failing test is a known issue unrelated to this PR

Copy link
Contributor

@tverbeiren tverbeiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DriesSchaumont DriesSchaumont merged commit d0694ac into main Oct 28, 2023
@DriesSchaumont DriesSchaumont deleted the 600-move-workflows-to-src branch October 28, 2023 05:53
@DriesSchaumont DriesSchaumont mentioned this pull request Jan 4, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move workflows to /src
2 participants