Skip to content

Adding new method: DRVI #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 11, 2025
Merged

Adding new method: DRVI #61

merged 10 commits into from
Aug 11, 2025

Conversation

seohyonkim
Copy link
Contributor

@seohyonkim seohyonkim commented Jun 2, 2025 •
edited by mumichae
Loading

Describe your changes

This is a PR to add a new method, DRVI into the batch integration tasks.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@mumichae mumichae self-requested a review June 2, 2025 13:54
mumichae
mumichae reviewed Jun 2, 2025
View reviewed changes
mumichae
mumichae requested changes Jun 2, 2025
View reviewed changes
Copy link
Collaborator

@mumichae mumichae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I flagged some redundant preprocessing code in the script that shouldn't be part of this module

mumichae
mumichae reviewed Jun 2, 2025
View reviewed changes
@seohyonkim seohyonkim marked this pull request as draft June 2, 2025 14:35
@mumichae mumichae marked this pull request as ready for review June 2, 2025 17:29
mumichae
mumichae requested changes Jul 22, 2025
View reviewed changes
@seohyonkim seohyonkim requested a review from mumichae July 23, 2025 11:08
mumichae
mumichae requested changes Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@mumichae mumichae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Could you also add a new entry to the Changelog?

seohyonkim and others added 3 commits July 23, 2025 21:28
@seohyonkim @mumichae
Update src/methods/drvi/script.py
21751a8 
Co-authored-by: Michaela Müller <51025211+mumichae@users.noreply.github.com>
@seohyonkim @mumichae
Update src/methods/drvi/config.vsh.yaml
927b6dc 
Co-authored-by: Michaela Müller <51025211+mumichae@users.noreply.github.com>
@seohyonkim
add changelog entry
33c4d83
@seohyonkim
Copy link
Contributor Author

@mumichae Thank you for the review! Changelog is added :)

@rcannood rcannood requested a review from mumichae August 8, 2025 14:31
@rcannood
Copy link
Member

rcannood commented Aug 8, 2025

@mumichae Is this ready to be merged?

@mumichae mumichae merged commit c6bb27a into openproblems-bio:main Aug 11, 2025
2 checks passed
lazappi added a commit that referenced this pull request Aug 13, 2025
@lazappi
Merge remote-tracking branch 'origin/main' into feature/no-ref/add-ml…
f179613 
…flow-models

* origin/main:
  Adding new method: DRVI (#61)
  update scprint (#70)
  Adding a new metric BRAS(Batch Removal Adapted Silhouette) (#62)
@cmclean cmclean mentioned this pull request Sep 19, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumichae mumichae mumichae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seohyonkim @rcannood @mumichae