Skip to content

update scprint #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2025
Merged

update scprint #70

merged 1 commit into from
Aug 9, 2025

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Aug 8, 2025

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@rcannood
Copy link
Member Author

rcannood commented Aug 8, 2025

@jkobject Does this PR seem ok to you?

@rcannood rcannood requested review from lazappi and mumichae and removed request for lazappi August 8, 2025 14:26
@rcannood
Copy link
Member Author

rcannood commented Aug 8, 2025

@mumichae scprint was failing, so I updated it. Does this PR look ok to you?

@rcannood
Copy link
Member Author

rcannood commented Aug 9, 2025

Merging this PR to get the main branch to build :)

@rcannood rcannood merged commit f738810 into main Aug 9, 2025
2 checks passed
@rcannood rcannood deleted the fix-scprint branch August 9, 2025 18:38
@jkobject
Copy link
Contributor

Hi,
I just saw this PR, scPRINT was working on my end before at this version but maybe some package got updated under the hood. Updating scPRINT can be a good idea but a few things have changed in the newer version. I will try to quickly test if it runs and push a PR

@jkobject
Copy link
Contributor

I will have to push a similar PR on all 4 scprint tasks grn / denoise / cell type annotation

lazappi added a commit that referenced this pull request Aug 13, 2025
@lazappi
Merge remote-tracking branch 'origin/main' into feature/no-ref/add-ml…
f179613 
…flow-models

* origin/main:
  Adding new method: DRVI (#61)
  update scprint (#70)
  Adding a new metric BRAS(Batch Removal Adapted Silhouette) (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumichae mumichae Awaiting requested review from mumichae

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcannood @jkobject