Skip to content

Conversation

Csantucci
Copy link
Contributor

@Csantucci Csantucci commented Dec 12, 2021

@Csantucci Csantucci added the enhancement New feature or request label Dec 12, 2021
pzgulyas
pzgulyas previously approved these changes Dec 14, 2021
Copy link
Contributor

@pzgulyas pzgulyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No obvious error hits my eyes, I find it all right.

twpol pushed a commit that referenced this pull request Dec 14, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures
- Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters
- Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 )
- Pull request #537 at e753905: C# signal script extensions
- Pull request #541 at 9094261: Initial Virtual File System development
- Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs
- Pull request #543 at 5b0121c: adds Discover > Roadmap webpage
- Pull request #545 at 32b8d28: Fix VRAM usage
- Pull request #546 at 3be6354: Blueprint https://blueprints.launchpad.net/or/+spec/multiple-screen-pages in 2D and 3D cabs
@Csantucci
Copy link
Contributor Author

Hi Peter,
thank you also here! This PR clashed with my other one, because they intervene in the same files, so, now that the other one is merged, I had to update this one. Therefore I am kindly asking you to approve it again.

twpol pushed a commit that referenced this pull request Dec 14, 2021
- Pull request #525 at b5ac1d2: Add SignalTypeName and DrawStateName to SignalFeatures
- Pull request #527 at 27f05a1: Brake cuts power refactor and new parameters
- Pull request #533 at 62a1c27: fix for shapes hidden by animations( 0 )
- Pull request #537 at e753905: C# signal script extensions
- Pull request #541 at b3f673f: Initial Virtual File System development
- Pull request #542 at 83320ed: adds new webpage, moves Testing out of Download/Programs
- Pull request #543 at 5b0121c: adds Discover > Roadmap webpage
- Pull request #545 at 32b8d28: Fix VRAM usage
- Pull request #546 at 3be6354: Blueprint https://blueprints.launchpad.net/or/+spec/multiple-screen-pages in 2D and 3D cabs
Copy link
Contributor

@pzgulyas pzgulyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay!

@Csantucci
Copy link
Contributor Author

Wow, that was fast! :)

@Csantucci Csantucci merged commit 55f3ff8 into openrails:master Dec 14, 2021
@twpol twpol changed the title Blueprint https://blueprints.launchpad.net/or/+spec/multiple-screen-pages in 2D and 3D cabs Multiple screen pages in 2D and 3D cabs May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants