Azure: Add EncryptionType field to ManagedDiskParameters #1118
Conversation
This allows the type of Azure disk encryption to be specified.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jhixson74 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jhixson74: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Is there any enhancement or documentation that explains what this new field is doing? I don't know anything about these encryption types or how they might be used
Are there any caveats to these? Do customers need to set anything up before they can use the different types? Are there compatibility issues that mean other options are restricted when using these options?
| // EncryptionType is the type of diisk encryption used. | ||
| // Possible values include: 'EncryptionAtRestWithPlatformKey', 'EncryptionAtRestWithCustomerKey', and 'EncryptionAtRestWithPlatformAndCustomerKeys'. | ||
| // +optional | ||
| EncryptionType string `json:"encryptionType,omitempty"` |
There was a problem hiding this comment.
We tend to make enums like this a typed string with specific values as constants, the constants can then be used in implementation to validate the valid values
There was a problem hiding this comment.
As far as I know stuff in here must correspond to the Azure SDK/Client which in turn corresponds to Azure API. And there is no such filed in the Azure API as encryption type.
There was a problem hiding this comment.
@jhixson74 I believe no changes required in this repo to enable server side encryption or encryption at host. We already have DiskEncryptionSet and this is what we need.
| // EncryptionType is the type of diisk encryption used. | ||
| // Possible values include: 'EncryptionAtRestWithPlatformKey', 'EncryptionAtRestWithCustomerKey', and 'EncryptionAtRestWithPlatformAndCustomerKeys'. | ||
| // +optional | ||
| EncryptionType string `json:"encryptionType,omitempty"` |
There was a problem hiding this comment.
As far as I know stuff in here must correspond to the Azure SDK/Client which in turn corresponds to Azure API. And there is no such filed in the Azure API as encryption type.
3 participants
This allows the type of Azure disk encryption to be specified.
https://issues.redhat.com/browse/CORS-1889
https://issues.redhat.com/browse/CORS-1890
https://issues.redhat.com/browse/CORS-1891