Skip to content

Azure: Add EncryptionType field to ManagedDiskParameters #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Azure: Add EncryptionType field to ManagedDiskParameters #1118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions machine/v1beta1/types_azureprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,10 @@ type ManagedDiskParameters struct {
// DiskEncryptionSet is the disk encryption set properties
// +optional
DiskEncryptionSet *DiskEncryptionSetParameters `json:"diskEncryptionSet,omitempty"`
// EncryptionType is the type of diisk encryption used.
// Possible values include: 'EncryptionAtRestWithPlatformKey', 'EncryptionAtRestWithCustomerKey', and 'EncryptionAtRestWithPlatformAndCustomerKeys'.
// +optional
EncryptionType string `json:"encryptionType,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to make enums like this a typed string with specific values as constants, the constants can then be used in implementation to validate the valid values

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know stuff in here must correspond to the Azure SDK/Client which in turn corresponds to Azure API. And there is no such filed in the Azure API as encryption type.

}

// DiskEncryptionSetParameters is the disk encryption set properties
Expand Down