STOR-1119, STOR-751: CSI migration for vSphere and Azure file are GA

[bertinatto]

CC @openshift/storage

[openshift-ci]

Hello @bertinatto! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label <labelname> command.

Who should apply these qe/docs/px labels?

• For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
• For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
• For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

[bertinatto]

/jira refresh

[openshift-ci-robot]

@bertinatto: No Jira bug is referenced in the title of this pull request.
To reference a bug, add 'OCPBUGS-XXX:' to the title of this pull request and request another bug refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bertinatto]

/assign @gnufied

[dobsonj]

/lgtm

[jsafrane]

For reviewers, this would be nice to have before rebase to Kubernetes 1.26 lands. The feature gates are beta (enabled) in upstream Kubernetes 1.25 and we disable them in 4.12 via these feature gates. They are GA in 1.26 and cannot be disabled there. Using them as --feature-gate on cmdline results in warnings.

[JoelSpeed]

Things I would like to see documented within the comments/description of the PR before we proceed in merging this:

• Evidence that this feature is working as expected - links to test results (can be from TechPreview if they show the storage is working as expected)
• Clarification on repositories that need to be updated once this is merged, links to any PRs for those, and notes on any ordering or dependencies between those PRs

Otherwise, the logic of getting this merged and through so that storage can prove this is working before the rebase makes sense to me

[bertinatto]

CSI migration for vSphere and Azure File are currently Tech Preview, so we can use related jobs to confirm the feature is working:

vSphere

• https://testgrid.k8s.io/redhat-openshift-ocp-release-4.12-informing#periodic-ci-openshift-release-master-nightly-4.12-e2e-vsphere-ovn-techpreview
• Generic ephemeral tests should be fixed with OCPBUGS-2927: [release-4.12] Bump kubernetes to latest release-4.12 origin#27588. Waiting for a job run that confirms that.

Azure File

• https://testgrid.k8s.io/redhat-openshift-ocp-release-4.12-informing#periodic-ci-openshift-release-master-ci-4.12-e2e-azure-sdn-techpreview
• Azure File tests are passing, job is failing for unrelated reasons.

[bertinatto]

Placeholder PRs to bump openshift/api (using this PR). This is currently being used to manually test the changes in the VMC environment:

• KCM operator: [WIP] Bump openshift/api: to get CSI migration for vSphere and Azure File cluster-kube-controller-manager-operator#672
• Apiserver operator: [WIP] Bump openshift/api: to get CSI migration for vSphere and Azure File cluster-kube-apiserver-operator#1414
• Scheduler operator: [WIP] Bump openshift/api: to get CSI migration for vSphere and Azure File  cluster-kube-scheduler-operator#450
• MCO: [WIP] Bump openshift/api: to get CSI migration for vSphere and Azure File machine-config-operator#3443

Because of the carry-patches we have in k/o, the ordering which these PRs merge doesn't matter much, but we will merge MCO last because to make the operation more atomic (Attach Detach Controller (KCM) will effectively enable the CSI migration only after the Kubelet does that).

[JoelSpeed]

Thanks @bertinatto @jsafrane for the additional context, you may merge this when you are ready
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dobsonj, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bertinatto]

/label docs-approved
/label px-approved

[bertinatto]

/label qe-approved
This is required to merge for the k8s 1.26 rebase.

[openshift-ci]

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.