Skip to content

Conversation

sohankunkerkar
Copy link
Member

Related to https://issues.redhat.com/browse/OCPNODE-2217

This commit sets crun as the default container runtime in OCP for 4.17

Copy link
Contributor

openshift-ci bot commented Jun 10, 2024

Hello @sohankunkerkar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2024
@sohankunkerkar sohankunkerkar changed the title machineconfiguration: make crun as the default container runtime [OCPNODE-2357] machineconfiguration: make crun as the default container runtime Jun 10, 2024
@sohankunkerkar sohankunkerkar changed the title [OCPNODE-2357] machineconfiguration: make crun as the default container runtime OCPNODE-2357: machineconfiguration: make crun as the default container runtime Jun 10, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2024

@sohankunkerkar: This pull request references OCPNODE-2357 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/OCPNODE-2217

This commit sets crun as the default container runtime in OCP for 4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sohankunkerkar
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 10, 2024

@sohankunkerkar: This pull request references OCPNODE-2357 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rphillips
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2024
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from the MCO perspective.

I guess this PR by itself doesn't affect anything, and the MCO PR will be where we do the testing?

Copy link
Contributor

openshift-ci bot commented Jun 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rphillips, sohankunkerkar, yuqi-zhang
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

@sohankunkerkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview 4248c11 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift 4248c11 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-aws-serial-techpreview 4248c11 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade-minor 4248c11 link true /test e2e-upgrade-minor
ci/prow/e2e-aws-serial 4248c11 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn 4248c11 link true /test e2e-aws-ovn
ci/prow/e2e-upgrade 4248c11 link true /test e2e-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2024
@sohankunkerkar sohankunkerkar deleted the crun-default-4.17 branch November 19, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants