-
Notifications
You must be signed in to change notification settings - Fork 573
OCPNODE-2357: machineconfiguration: make crun as the default container runtime #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Related to https://issues.redhat.com/browse/OCPNODE-2217 Signed-off-by: Sohan Kunkerkar <sohank2602@gmail.com>
Hello @sohankunkerkar! Some important instructions when contributing to openshift/api: |
@sohankunkerkar: This pull request references OCPNODE-2357 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@sohankunkerkar: This pull request references OCPNODE-2357 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving from the MCO perspective.
I guess this PR by itself doesn't affect anything, and the MCO PR will be where we do the testing?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rphillips, sohankunkerkar, yuqi-zhang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sohankunkerkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Related to https://issues.redhat.com/browse/OCPNODE-2217
This commit sets crun as the default container runtime in OCP for 4.17