Skip to content

MON-4359: Add Monitoring Capability #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MON-4359: Add Monitoring Capability #2468

wants to merge 1 commit into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Sep 3, 2025

Add a "Monitoring" capability to support optional monitoring.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 3, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

Hello @rexagod! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 3, 2025
rexagod added a commit to rexagod/cluster-version-operator that referenced this pull request Sep 3, 2025
@rexagod
MON-X: Bump API version to include monitoring capability
949b387 
Blocked by: openshift/api#2468

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod rexagod mentioned this pull request Sep 3, 2025
Draft
@rexagod rexagod changed the title MON-X: Add Monitoring Capability MON-4359: Add Monitoring Capability Sep 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 3, 2025 •
edited by openshift-ci bot
Loading

@rexagod: This pull request references MON-4359 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Add a "Monitoring" capability to support optional monitoring.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rexagod rexagod force-pushed the opt-monitoring-capability branch 2 times, most recently from cc7f11d to 6d757d5 Compare September 29, 2025 02:11
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod
MON-4359: Add Monitoring Capability
72b018d 
Add an "OptionalMonitoring" capability to support optional monitoring.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod rexagod force-pushed the opt-monitoring-capability branch from 6d757d5 to 72b018d Compare September 29, 2025 02:26
@rexagod rexagod marked this pull request as ready for review September 29, 2025 02:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

everettraven
everettraven reviewed Sep 29, 2025
View reviewed changes
config/v1/types_cluster_version.go

// ClusterVersionCapabilityOptionalMonitoring manages the cluster monitoring stack which is responsible for gathering and
// processing metrics from the in-house and user workloads. The following CRDs are constitute this capability:
// - TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably we should not add this capability until we know the full scope of what this capability will and will not do?

config/v1/types_cluster_version.go
Comment on lines +407 to +409
// WARNING: This capability will drop all aforementioned CRDs, and may operational issues in the cluster.
// The only supported use-case for this capability is to reduce the monitoring stack's resource usage by only
// supporting telemetry.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What operational issues may happen here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "only supporting telemetry" mean here?

config/v1/types_cluster_version.go
ClusterVersionCapabilityCloudControllerManager ClusterVersionCapability = "CloudControllerManager"

// ClusterVersionCapabilityOptionalMonitoring manages the cluster monitoring stack which is responsible for gathering and
// processing metrics from the in-house and user workloads. The following CRDs are constitute this capability:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only these CRDs that are removed when this capability is disabled? Are there default monitoring workloads that may no longer be running on the cluster when this is disabled?

config/v1/types_cluster_version.go
ClusterVersionCapabilitySet4_18 ClusterVersionCapabilitySet = "v4.18"

// ClusterVersionCapabilitySet4_19 is the recommended set of
// optional capabilities to enable for the 4.18 version of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// optional capabilities to enable for the 4.18 version of
// optional capabilities to enable for the 4.19 version of

config/v1/types_cluster_version.go
ClusterVersionCapabilitySet4_19 ClusterVersionCapabilitySet = "v4.19"

// ClusterVersionCapabilitySet4_20 is the recommended set of
// optional capabilities to enable for the 4.18 version of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// optional capabilities to enable for the 4.18 version of
// optional capabilities to enable for the 4.20 version of

config/v1/types_cluster_version.go
ClusterVersionCapabilityCloudCredential,
ClusterVersionCapabilityIngress,
ClusterVersionCapabilityCloudControllerManager,
ClusterVersionCapabilityOptionalMonitoring,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this be included in the 4.19 set if the capability does not exist in 4.19?

config/v1/types_cluster_version.go
ClusterVersionCapabilityCloudCredential,
ClusterVersionCapabilityIngress,
ClusterVersionCapabilityCloudControllerManager,
ClusterVersionCapabilityOptionalMonitoring,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this be included in the 4.20 capability list if this capability does not exist in 4.20?

@everettraven
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

1 more reviewer

@everettraven everettraven everettraven left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@everettraven everettraven

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rexagod @openshift-ci-robot @everettraven