Skip to content

Conversation

isabella-janssen
Copy link
Member

This is a manual cherry-pick of #2497 since the automated cherry-pick failed.

Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2025
@isabella-janssen
Copy link
Member Author

/jira cherrypick OCPBUGS-61977

@openshift-ci-robot
Copy link

@isabella-janssen: Jira Issue OCPBUGS-61977 has been cloned as Jira Issue OCPBUGS-62155. Will retitle bug to link to clone.
/retitle OCPBUGS-62155: Add 'AGE' print column to MachineConfigNode object

In response to this:

/jira cherrypick OCPBUGS-61977

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Add 'AGE' print column to MachineConfigNode object OCPBUGS-62155: Add 'AGE' print column to MachineConfigNode object Sep 24, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 24, 2025
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-62155, which is invalid:

  • expected dependent Jira Issue OCPBUGS-61977 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #2497 since the automated cherry-pick failed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jkyros and JoelSpeed September 24, 2025 13:45
@isabella-janssen isabella-janssen changed the title OCPBUGS-62155: Add 'AGE' print column to MachineConfigNode object [release-4.19] OCPBUGS-62155: Add 'AGE' print column to MachineConfigNode object Sep 24, 2025
@JoelSpeed
Copy link
Contributor

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@openshift-ci-robot
Copy link

/test remaining-required

Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

@openshift-ci-robot: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test images
/test integration
/test lint
/test okd-scos-images
/test unit
/test verify
/test verify-client-go
/test verify-crd-schema
/test verify-deps
/test verify-feature-promotion

The following commands are available to trigger optional jobs:

/test e2e-azure
/test e2e-gcp
/test okd-scos-e2e-aws-ovn

Use /test all to run all jobs.

In response to this:

/test remaining-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2025
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

@isabella-janssen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn e4ab636 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp e4ab636 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@isabella-janssen
Copy link
Member Author

/verified by @isabella-janssen

Verified in a 4.19 cluster with this PR included:

$ oc get machineconfignode
NAME                           POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE
ip-10-0-114-27.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m
ip-10-0-117-237.ec2.internal   master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m
ip-10-0-44-187.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m
$ oc get machineconfignode -o wide
NAME                           POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE     UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-114-27.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m     False            False            False                      False            True      False               False          False         False          False
ip-10-0-117-237.ec2.internal   master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m     False            False            False                      False            False     False               False          False         False          False
ip-10-0-44-187.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m     False            False            False                      False            True      False               False          False         False          False

I'll refresh the Jira label once the 4.20 bug is in the VERIFIED state.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 24, 2025
@openshift-ci-robot
Copy link

@isabella-janssen: This PR has been marked as verified by @isabella-janssen.

In response to this:

/verified by @isabella-janssen

Verified in a 4.19 cluster with this PR included:

$ oc get machineconfignode
NAME                           POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE
ip-10-0-114-27.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m
ip-10-0-117-237.ec2.internal   master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m
ip-10-0-44-187.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m
$ oc get machineconfignode -o wide
NAME                           POOLNAME   DESIREDCONFIG                                      CURRENTCONFIG                                      UPDATED   AGE     UPDATEPREPARED   UPDATEEXECUTED   UPDATEPOSTACTIONCOMPLETE   UPDATECOMPLETE   RESUMED   UPDATEDFILESANDOS   CORDONEDNODE   DRAINEDNODE   REBOOTEDNODE   UNCORDONEDNODE
ip-10-0-114-27.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m     False            False            False                      False            True      False               False          False         False          False
ip-10-0-117-237.ec2.internal   master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m     False            False            False                      False            False     False               False          False         False          False
ip-10-0-44-187.ec2.internal    master     rendered-master-6e954cfcf8c11771f9069f2edf6d1475   rendered-master-6e954cfcf8c11771f9069f2edf6d1475   True      65m     False            False            False                      False            True      False               False          False         False          False

I'll refresh the Jira label once the 4.20 bug is in the VERIFIED state.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@isabella-janssen
Copy link
Member Author

/jira refresh
/retest-required

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 25, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 25, 2025
@openshift-ci-robot
Copy link

@isabella-janssen: This pull request references Jira Issue OCPBUGS-62155, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-61977 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-61977 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh
/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergiordlr September 25, 2025 13:43
@openshift-merge-bot openshift-merge-bot bot merged commit 079ac08 into openshift:release-4.19 Sep 25, 2025
23 of 25 checks passed
@openshift-ci-robot
Copy link

@isabella-janssen: Jira Issue Verification Checks: Jira Issue OCPBUGS-62155
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-62155 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

This is a manual cherry-pick of #2497 since the automated cherry-pick failed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants