-
Notifications
You must be signed in to change notification settings - Fork 574
CONSOLE-2266: Add Console QuickStart CRD #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @jhadvig. I made some suggestions on the API doc descriptions.
d0fe1d5
to
9a8eadf
Compare
@spadgett comments addressed. Added the validation as well + one comment. PTAL |
@spadgett @christianvogt PR updated |
@christianvogt @spadgett comments addressed |
/assign @bparees /assign @ahardin-rh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the "console" prefix seems unnecessary/redundant in most of the places it is used, including the CRD name itself.
@bparees comment addressed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I'm leaving final tags to Ben and Sam
@jhadvig i still see numerous unresolved comment threads, please reply to them and/or mark them resolved (if they are) |
@andrewballantyne there should not be anything, based on the Slack conversations. I've resolved all the comments and the PR should be ready to get merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhadvig, soltysh, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Story: https://issues.redhat.com/browse/CONSOLE-2266
Will generate the CRD once we align on the api. PTAL
/assign @spadgett
cc'ing @rohitkrai03 @christianvogt