Bug 1949799: Set maximum for ingresscontroller spec.tuningOptions.threadCount to 64

[rfredette]

As of this PR, HAProxy only supports up to 64 threads

[openshift-ci-robot]

@rfredette: This pull request references Bugzilla bug 1949799, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.8.0) matches configured target release for branch (4.8.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

Bug 1949799: Set maximum for ingresscontroller spec.tuningOptions.threadCount to 64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rfredette
To complete the pull request process, please assign derekwaynecarr after the PR has been reviewed.
You can assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

You're changing a value from previously unbounded? What is the chance that this value is currently set higher than 64 in existing clusters?

[rfredette]

The field is new in 4.8, but even if someone is running a 4.8 pre-release build and threadCound is set above 64, HAProxy exits with a fatal error and the router pods quickly end up in CrashLoopBackOff state, so it shouldn't be possible that a working cluster has threadCount set above 64.

[frobware]

I think the review comments are addressed. Can we move this along now?

[frobware]

/lgtm

[deads2k]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, frobware, rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rfredette: All pull requests linked via external trackers have merged:

• openshift/api#920

Bugzilla bug 1949799 has been moved to the MODIFIED state.

In response to this:

Bug 1949799: Set maximum for ingresscontroller spec.tuningOptions.threadCount to 64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.