-
Notifications
You must be signed in to change notification settings - Fork 574
Bug 1949799: Set maximum for ingresscontroller spec.tuningOptions.threadCount to 64 #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -981,15 +981,17 @@ spec: | |
description: "threadCount defines the number of threads created | ||
per HAProxy process. Creating more threads allows each ingress | ||
controller pod to handle more connections, at the cost of more | ||
system resources being used. If this field is empty, the IngressController | ||
will use the default value. The current default is 4 threads, | ||
but this may change in future releases. \n Setting this field | ||
is generally not recommended. Increasing the number of HAProxy | ||
system resources being used. HAProxy currently supports up to | ||
64 threads. If this field is empty, the IngressController will | ||
use the default value. The current default is 4 threads, but | ||
this may change in future releases. \n Setting this field is | ||
generally not recommended. Increasing the number of HAProxy | ||
threads allows ingress controller pods to utilize more CPU time | ||
under load, potentially starving other pods if set too high. | ||
Reducing the number of threads may cause the ingress controller | ||
to perform poorly." | ||
format: int32 | ||
maximum: 64 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You're changing a value from previously unbounded? What is the chance that this value is currently set higher than 64 in existing clusters? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The field is new in 4.8, but even if someone is running a 4.8 pre-release build and |
||
minimum: 1 | ||
type: integer | ||
type: object | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.