Skip to content

Conversation

wking
Copy link
Member

@wking wking commented Oct 15, 2020

Catching up with openshift/release@5cf5ba3f87
(core-services/prow/02_config/generate-boskos: For spitting out lots
of names, 2020-09-10, openshift/release#11752).
@wking wking force-pushed the document-boskos-generator branch from c0f6ac0 to 2a1920b Compare October 15, 2020 04:42
max-count: 10 # set equal to `min-count`
required. The configuration is checked into source control:

* [generator](https://github.com/openshift/release/blob/master/core-services/prow/02_config/generate-boskos.py)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its still possible to manually add resources to the config or not?

Copy link
Member Author

@wking wking Oct 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, because of the presubmit @stevekuznetsov requested for openshift/release#11752. See also the "do not edit directly" comment.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2f7033e into openshift:master Oct 19, 2020
@wking wking deleted the document-boskos-generator branch October 20, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants