Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1833385: Allows users to configure any non-link-local IPV6 address for the provisioning interface #78

Merged
merged 1 commit into from
May 8, 2020

Conversation

mvazquezc
Copy link
Member

@mvazquezc mvazquezc commented May 7, 2020

This fix introduces the fix created for metal3-io ironic-image metal3-io#156

Thanks @maelk for fixing our previous fix!

@mvazquezc
Copy link
Member Author

/assign @bfournie

@russellb
Copy link
Member

russellb commented May 8, 2020

/approve
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mvazquezc, russellb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 8, 2020
@russellb
Copy link
Member

russellb commented May 8, 2020

/hold

Can you go ahead and file a 4.5 bz for this?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2020
@russellb
Copy link
Member

russellb commented May 8, 2020

/hold cancel

don't need the hold, prow is already waiting for the bugzilla/valid-bug label

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2020
@mvazquezc
Copy link
Member Author

/cherry-pick release-4.4

@openshift-cherrypick-robot

@mvazquezc: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link

jparrill commented May 8, 2020

/retitle bug 1833385: Allows users to configure any non-link-local IPV6 address for the provisioning interface

@openshift-ci-robot openshift-ci-robot changed the title Allows users to configure any non-link-local IPV6 address for the provisioning interface bug 1833385: Allows users to configure any non-link-local IPV6 address for the provisioning interface May 8, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 8, 2020
@openshift-ci-robot
Copy link

@mvazquezc: This pull request references Bugzilla bug 1833385, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

bug 1833385: Allows users to configure any non-link-local IPV6 address for the provisioning interface

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jparrill
Copy link

jparrill commented May 8, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 8, 2020
@openshift-ci-robot
Copy link

@jparrill: This pull request references Bugzilla bug 1833385, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5023ddf into openshift:master May 8, 2020
@openshift-ci-robot
Copy link

@mvazquezc: All pull requests linked via external trackers have merged: metal3-io/ironic-image#153, openshift/ironic-image#78. Bugzilla bug 1833385 has been moved to the MODIFIED state.

In response to this:

bug 1833385: Allows users to configure any non-link-local IPV6 address for the provisioning interface

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mvazquezc: new pull request created: #79

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants