Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: carry: limit SAR retries to 3 #409

Closed
wants to merge 1,432 commits into from

Conversation

tkashem
Copy link

@tkashem tkashem commented Oct 15, 2020

No description provided.

k8s-ci-robot and others added 30 commits September 29, 2020 02:49
…bounds-client-side

kubeadm: print warnings on invalid cert period instead of erroring out
…rt_renew

kubeadm: add note for kubeadm cert renew
…hanges

Watch bookmarks may contain version of objects of other types
Add LookForStringInPodExecToContainer(...) that takes container name as argument.
…-selectorspread/podtopologyspread

wrap errors in selectorspread and podtoplogyspread plugin
kubernetes/sample-apiserver: correct 'admission' spelling errors
kubernetes/sample-apiserver: correct 'information' spelling errors
add configuration for controller migration.
Update Windows image version to the latest one. This one includes a fix
for unix domain socket
Add csi proxy log
Convert to EphemeralContainers for validation in EphemeralContainersREST
These were already fatal errors in NewMainKubelet()
remove iperf e2e test ip family tags
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tkashem
To complete the pull request process, please assign derekwaynecarr, smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @derekwaynecarr @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem tkashem force-pushed the webhook-retry branch 19 times, most recently from 93bb2f8 to c00ffe3 Compare October 21, 2020 14:17
@deads2k
Copy link

deads2k commented Oct 21, 2020

/hold

this won't do what you need. You need to open against the openshift-apiserver fork for kubernetes-apiserver.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2020
Currently webhook retry backoff parameters are hardcoded, we want to
give the caller the ability to configure the backoff parameters for
webhook request retry:
The default backoff parameters from today will continue to be in effect
after this change. we are solely making it configurable here.
Ensure that total duration in webhook request retries do not exceed
the context deadline associated with the originating request.
@openshift-merge-robot
Copy link

@tkashem: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-upgrade 93bb2f87ef998f63172545816d5a232b90a3bb3e link /test e2e-azure-upgrade
ci/prow/e2e-aws-selfupgrade 93bb2f87ef998f63172545816d5a232b90a3bb3e link /test e2e-aws-selfupgrade
ci/prow/e2e-aws-upgrade 93bb2f87ef998f63172545816d5a232b90a3bb3e link /test e2e-aws-upgrade
ci/prow/artifacts f410949 link /test artifacts
ci/prow/e2e-aws-fips f410949 link /test e2e-aws-fips
ci/prow/e2e-gcp f410949 link /test e2e-gcp
ci/prow/k8s-e2e-gcp f410949 link /test k8s-e2e-gcp
ci/prow/images f410949 link /test images
ci/prow/k8s-e2e-gcp-serial f410949 link /test k8s-e2e-gcp-serial
ci/prow/verify-commits f410949 link /test verify-commits
ci/prow/e2e-aws-csi f410949 link /test e2e-aws-csi
ci/prow/unit f410949 link /test unit
ci/prow/e2e-aws-serial f410949 link /test e2e-aws-serial
ci/prow/verify f410949 link /test verify
ci/prow/integration f410949 link /test integration
ci/prow/e2e-cmd f410949 link /test e2e-cmd
ci/prow/e2e-gcp-upgrade f410949 link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tkashem
Copy link
Author

tkashem commented Oct 21, 2020

/close

once kubernetes#95705 merges I will open a new PR in openshift-apiserver fork for kubernetes-apiserver.

@openshift-ci-robot
Copy link

@tkashem: Closed this PR.

In response to this:

/close

once kubernetes#95705 merges I will open a new PR in openshift-apiserver fork for kubernetes-apiserver.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.