Skip to content

Conversation

ingvagabund
Copy link
Member

Reverts #155 and keeps only the providerSpec field.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ingvagabund

If they are not already assigned, you can assign the PR to them by writing /assign @ingvagabund in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@enxebre
Copy link
Member

enxebre commented Jan 9, 2019

before merging this, please make sure to update https://github.com/openshift/console/search?q=providerConfig&unscoped_q=providerConfig

@enxebre enxebre added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2019
@ingvagabund ingvagabund closed this Jan 9, 2019
@ingvagabund ingvagabund deleted the revert-155-change_crds_definitions branch January 9, 2019 12:46
@openshift-ci-robot
Copy link
Contributor

@ingvagabund: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws b9cdadd link /test e2e-aws
ci/prow/e2e-aws-operator b9cdadd link /test e2e-aws-operator
ci/prow/images b9cdadd link /test images

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
client: add cluster-api-provider-aws to UserAgent for AWS API calls
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
…_identity

update golang.org/x/oauth2 to support gcp workload identity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants