Skip to content

Revert 155 change crds definitions and rename providerConfig to providerSpec #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Revert 155 change crds definitions and rename providerConfig to providerSpec #168

wants to merge 4 commits into from

Conversation

ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Jan 9, 2019 •
edited
Loading

Reverting #155 and renaming providerConfig to providerSpec

Plus, building on top of #169.

TODO

/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ingvagabund

If they are not already assigned, you can assign the PR to them by writing /assign @ingvagabund in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member Author

#167 (comment) needs to be resolved first

@enxebre
Copy link
Member

enxebre commented Jan 9, 2019

Before merging this please make sure this is updated https://github.com/openshift/console/search?q=providerConfig&unscoped_q=providerConfig

@ingvagabund ingvagabund changed the title Revert 155 change crds definitions Revert 155 change crds definitions and rename providerConfig to providerSpec Jan 9, 2019
@ingvagabund
Copy link
Member Author

Before merging this please make sure this is updated https://github.com/openshift/console/search?q=providerConfig&unscoped_q=providerConfig

openshift/console#1035

@ingvagabund ingvagabund force-pushed the revert-155-change_crds_definitions branch 2 times, most recently from d9813c6 to e7f78db Compare January 9, 2019 15:32
Artyom Lukianov and others added 4 commits January 9, 2019 16:51
@ingvagabund
Remove apiserver-builder dependency
3e239af
@ingvagabund
Revert "Support both providerConfig and providerSpec under machine CR…
c4e09da 
…D's"
@ingvagabund
Rename providerConfig to providerSpec
5438753
@ingvagabund
Update cluster-api dep to include ProviderSpec
5b1386b 
The test/integration code decodes machineset from yaml files
to machineset object. Thus, even the code under cluster-api
needs to be updated.
@ingvagabund ingvagabund force-pushed the revert-155-change_crds_definitions branch from e7f78db to 5b1386b Compare January 9, 2019 16:01
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 9, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2019 •
edited
Loading

@ingvagabund: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 5b1386b link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member Author

/hold

devel freeze on Friday, merging only important changes.

@enxebre
Copy link
Member

enxebre commented Jan 10, 2019

/test e2e-aws-operator

@enxebre
Copy link
Member

enxebre commented Jan 10, 2019 •
edited
Loading

/test e2e-aws

@ingvagabund
Copy link
Member Author

/test integration

@enxebre
Copy link
Member

enxebre commented Jan 10, 2019

Thanks! Please either rebase with only relevant commits and meaningful message or close in favour of #170

@ingvagabund
Copy link
Member Author

#170 is better choice

@ingvagabund ingvagabund deleted the revert-155-change_crds_definitions branch January 10, 2019 11:01
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
@openshift-merge-robot
Merge pull request openshift#168 from enxebre/e2e-pkg
46f4852 
E2e pkg
germanparente pushed a commit to germanparente/machine-api-operator that referenced this pull request Sep 23, 2025
@openshift-ci
Merge pull request openshift#168 from Fedosin/gcp_events
098a5ce 
Bug 1990447: Create event only if the machine was modified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulfantom paulfantom Awaiting requested review from paulfantom

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ingvagabund @openshift-ci-robot @enxebre