-
Notifications
You must be signed in to change notification settings - Fork 226
Remove apiserver-builder dependency #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove apiserver-builder dependency #169
Conversation
Hi @cynepco3hahue. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sigs.k8s.io/cluster-api
dep is not updated given this is only removal of github.com/kubernetes-incubator/apiserver-builder
dep. The few changes, the better.
/retest |
2 similar comments
/retest |
/retest |
/hold devel freeze on Friday, merging only important changes. |
@ingvagabund Hm why do you freeze master and just do not create a new release? |
there are still some changes that needs to go in so we have frozen all our repos to only allow fixes and planned features. Once done, we tag a new release and unfreeze the master. |
@ingvagabund You can cherry-pick change from the master to specific release... |
6db2d8a
to
1105a2f
Compare
/retest |
@ingvagabund Hi, can we please merge this PR? |
thanks!! |
deps: switch cluster-api dependency to use master branch
Get rid of
kubernetes-incubator/apiserver-builder
dependency.This package depends on release-1.9 or on release-1.12, in both cases it does not work with our dependencies and we have other alternatives to get k8s config.