Skip to content

Conversation

cynepco3hahue
Copy link

Get rid of kubernetes-incubator/apiserver-builder dependency.

This package depends on release-1.9 or on release-1.12, in both cases it does not work with our dependencies and we have other alternatives to get k8s config.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 9, 2019
@openshift-ci-robot
Copy link
Contributor

Hi @cynepco3hahue. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2019
@ingvagabund
Copy link
Member

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2019
@ingvagabund
Copy link
Member

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2019
Copy link
Member

@ingvagabund ingvagabund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sigs.k8s.io/cluster-api dep is not updated given this is only removal of github.com/kubernetes-incubator/apiserver-builder dep. The few changes, the better.

@ingvagabund
Copy link
Member

/retest

2 similar comments
@ingvagabund
Copy link
Member

/retest

@cynepco3hahue
Copy link
Author

/retest

@ingvagabund
Copy link
Member

/hold

devel freeze on Friday, merging only important changes.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2019
@cynepco3hahue
Copy link
Author

@ingvagabund Hm why do you freeze master and just do not create a new release?

@ingvagabund
Copy link
Member

ingvagabund commented Jan 10, 2019

@ingvagabund Hm why do you freeze master and just do not create a new release?

there are still some changes that needs to go in so we have frozen all our repos to only allow fixes and planned features. Once done, we tag a new release and unfreeze the master.

@cynepco3hahue
Copy link
Author

@ingvagabund You can cherry-pick change from the master to specific release...

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2019
@cynepco3hahue cynepco3hahue force-pushed the remove_apiserver_builder_dep branch from 6db2d8a to 1105a2f Compare January 20, 2019 10:15
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 20, 2019
@cynepco3hahue
Copy link
Author

/retest

@cynepco3hahue
Copy link
Author

@ingvagabund Hi, can we please merge this PR?

@enxebre
Copy link
Member

enxebre commented Jan 24, 2019

thanks!!
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2019
@enxebre enxebre removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit e71cdb9 into openshift:master Jan 24, 2019
ingvagabund pushed a commit to ingvagabund/machine-api-operator that referenced this pull request Jul 11, 2019
deps: switch cluster-api dependency to use master branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants