OBSINTA-858: Cypress incidents mocking metric name change workaround #553
Conversation
DavidRajnoha
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@DavidRajnoha: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
DavidRajnoha
force-pushed
the
cypress-incidents-mocking-metric-name-change-workaround
branch
from
fef1c69 to
a497fc0
Compare
web/cypress/support/incidents_prometheus_query_mocks/prometheus-mocks.ts
Outdated
Show resolved
Hide resolved
web/cypress/support/incidents_prometheus_query_mocks/prometheus-mocks.ts
Outdated
Show resolved
Hide resolved
DavidRajnoha
force-pushed
the
cypress-incidents-mocking-metric-name-change-workaround
branch
from
a497fc0 to
2901fea
Compare
cluster:health:components:map was changed to cluster_health_components_map. This commit updates the mocking to return the new metric and supports running tests in environments with old backend and new frontend. This workaround is by default disabled and will be fully removed after the COO 1.3.0 release
DavidRajnoha
force-pushed
the
cypress-incidents-mocking-metric-name-change-workaround
branch
from
2901fea to
73b8366
Compare
|
/lgtm |
|
/lgtm |
|
/label ux-approved |
openshift-ci
bot
added
the
ux-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidRajnoha, jgbernalp, sthundat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
DavidRajnoha
changed the title
|
@DavidRajnoha: This pull request references OBSINTA-858 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/override ci/prow/e2e-aws-ovn |
|
@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn |
|
@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@DavidRajnoha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
cluster:health:components:map was changed to cluster_health_components_map.
This PR updates the mocking to return the new metric and supports running tests in environments with old backend and new frontend.
This workaround is by default disabled and will be fully removed after the COO 1.3.0 release
Depends on #545