OBSINTA-858: Cypress incidents incident traversing robustness #556
Conversation
DavidRajnoha
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@DavidRajnoha: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cluster:health:components:map was changed to cluster_health_components_map. This commit updates the mocking to return the new metric and supports running tests in environments with old backend and new frontend. This workaround is by default disabled and will be fully removed after the COO 1.3.0 release
cluster:health:components:map was changed to cluster_health_components_map. This commit updates the mocking to return the new metric and supports running tests in environments with old backend and new frontend. This workaround is by default disabled and will be fully removed after the COO 1.3.0 release
cluster:health:components:map was changed to cluster_health_components_map. This commit updates the mocking to return the new metric and supports running tests in environments with old backend and new frontend. This workaround is by default disabled and will be fully removed after the COO 1.3.0 release
The UI changes introduced few quirks that break the traversal of incidents, but also solved some that had existing workarounds in the testsuite. This commit removes the retry for the not loading alerts chart, as it is loading reliably now, but because stale state is loaded first, it introduces hard coded wait time. Additionally, it fixes the failing traversal when no incidents exits in the UI and adds test case that verifies that on mocked data.
DavidRajnoha
force-pushed
the
cypress-incidents-incident-traversing-robustness
branch
from
e664bc7 to
91dc2bd
Compare
DavidRajnoha
changed the title
|
@DavidRajnoha: This pull request references OBSINTA-858 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@DavidRajnoha: This pull request references OBSINTA-858 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
ux-approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DavidRajnoha, jgbernalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/override ci/prow/okd-scos-e2e-aws-ovn |
|
@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/okd-scos-e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-ovn |
|
@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/e2e-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@DavidRajnoha: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The UI changes introduced few quirks that break the traversal of incidents, but also solved some that had existing workarounds in the testsuite.
This commit removes the retry for the not loading alerts chart, as it is loading reliably now, but because stale state is loaded first, it introduces hard coded wait time.
https://issues.redhat.com/browse/OU-1016 is the issue that this workaround is about. If it will be fixed, the workaround is to be replaced and the incident traversal will serve as a regression test for it.
Additionally, it fixes the failing traversal when no incidents exits in the UI and adds test case that verifies that on mocked data.
Depends on #553 so it is possible to test it with current setup (mocking and request transformation due to old new metric), but the changes are otherwise independent – That means it is ready for review.