Skip to content

Conversation

ibihim
Copy link

@ibihim ibihim commented Sep 19, 2024

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2024
@openshift-ci openshift-ci bot requested a review from deads2k September 19, 2024 13:01
Copy link

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibihim
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibihim ibihim force-pushed the ibihim/2024-09-19_fix-tests branch from 3b15a45 to 9828649 Compare September 20, 2024 10:48
@ibihim ibihim changed the title [wip] debugging OCPBUGS-42251: Fix oauth-proxy e2e-component tests. Sep 20, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 20, 2024
@ibihim ibihim changed the title OCPBUGS-42251: Fix oauth-proxy e2e-component tests. OCPBUGS-42251: Fix oauth-proxy e2e-component tests Sep 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 20, 2024
@openshift-ci-robot
Copy link

@ibihim: This pull request references Jira Issue OCPBUGS-42251, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ibihim
Copy link
Author

ibihim commented Sep 20, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 20, 2024
@openshift-ci-robot
Copy link

@ibihim: This pull request references Jira Issue OCPBUGS-42251, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xingxingxia

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xingxingxia September 20, 2024 10:59
@ibihim
Copy link
Author

ibihim commented Sep 20, 2024

/test e2e-component

@ibihim ibihim force-pushed the ibihim/2024-09-19_fix-tests branch from 9828649 to b3538d3 Compare September 20, 2024 13:24
@ibihim
Copy link
Author

ibihim commented Sep 20, 2024

/test unit

@ibihim
Copy link
Author

ibihim commented Oct 18, 2024

/retest-required

@ibihim ibihim force-pushed the ibihim/2024-09-19_fix-tests branch from 12f3250 to b3538d3 Compare October 18, 2024 18:03
@ShazaAldawamneh
Copy link

/retest-required

Copy link

openshift-ci bot commented Dec 2, 2024

@ibihim: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-component b3538d3 link true /test e2e-component

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b3538d3 into openshift:master Dec 2, 2024
5 of 7 checks passed
@openshift-ci-robot
Copy link

@ibihim: Jira Issue OCPBUGS-42251: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42251 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants