CORENET-5412: adm, inspect, ns: Collect UserDefinedNetwork CRs #2011
Conversation
OVN-Kubernetes (OVN-K) UserDefinedNetwork (UDN) is namespace-scope CRD that allows non-admin users create OVN-K user-defined networks w/o a cluster-admin intervention. Collect UDN CRs to allow troubleshooting them. Signed-off-by: Or Mergi <ormergi@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@ormergi: This pull request references CORENET-5412 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| @@ -31,6 +31,7 @@ func namespaceResourcesToCollect() []schema.GroupResource { | |||
| {Resource: "poddisruptionbudgets"}, | |||
| {Resource: "secrets"}, | |||
| {Resource: "servicemonitors"}, | |||
| {Resource: "userdefinednetworks"}, | |||
There was a problem hiding this comment.
As seen in the list, this list is very conservative and must be short. The recommended path is to add in must-gather (iff the collected data is small, because we have reached to a point where must-gather collection size and duration is not ideal currently)
/hold
There was a problem hiding this comment.
We anticipate that userdefinednetworks is gonna be used widely and multiple namespace may have a userdefinednetworks defined in it. With the lifting of featuregate for BGP, we anticipate more use of userdefinednetworks as main use case of BGP feature is to advertise UDNs.
routeadvertisements(main CRD to implement BGP) are cluster scoped resources and a PR for inclusion was accepted in the must-gather repository.
openshift/must-gather#485
openshift-ci
bot
added
the
do-not-merge/hold
|
@ardaguclu any update on this? userdefinednetworks CR definition is definitely gonna be needed to troubleshoot any issue related to it. |
Do you only want to get the yaml definition of UserDefinedNetworks CR in all namespaces?. Will there be any RelatedObjects defined in this resource that will trigger another nested resource inspection?. How much additional data will be more collected in must-gather and increase the output size?. Basically, I'm trying to assess that did you evaluate what are the consequence of adding this CR in here?. I'm sure that this is needed, but we can't add any resources that collects significant amount of data. |
Yes
OVNKubernetes creates a NetworkAttachmentDefinition corresponding to the userdefinednetwork CR but we dont need NetworkAttachmentDefinition. Even if e store both, I dont anticipate much resource consumption as both are lightweight.
A single UDN can take up to 4 KB. |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, ormergi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@ormergi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 8a28796
into
openshift:main
|
/cherry-pick release-4.19 |
|
@arghosh93: new pull request created: #2061 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
OVN-Kubernetes (OVN-K) UserDefinedNetwork (UDN) is namespace-scope CRD that allows non-admin users create OVN-K user-defined networks w/o a cluster-admin intervention.
Collect UDN CRs to allow troubleshooting them.