Skip to content

CORENET-5412: adm, inspect, ns: Collect UserDefinedNetwork CRs #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

CORENET-5412: adm, inspect, ns: Collect UserDefinedNetwork CRs #2011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/cli/admin/inspect/namespace.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ func namespaceResourcesToCollect() []schema.GroupResource {
{Resource: "poddisruptionbudgets"},
{Resource: "secrets"},
{Resource: "servicemonitors"},
{Resource: "userdefinednetworks"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As seen in the list, this list is very conservative and must be short. The recommended path is to add in must-gather (iff the collected data is small, because we have reached to a point where must-gather collection size and duration is not ideal currently)

/hold

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We anticipate that userdefinednetworks is gonna be used widely and multiple namespace may have a userdefinednetworks defined in it. With the lifting of featuregate for BGP, we anticipate more use of userdefinednetworks as main use case of BGP feature is to advertise UDNs.
routeadvertisements(main CRD to implement BGP) are cluster scoped resources and a PR for inclusion was accepted in the must-gather repository.
openshift/must-gather#485

}
}

Expand Down