Skip to content

Bug 1798571: [release-4.4] Make ObjectBucket & ObjectBucketClaim CRs owned and hide their APIs #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 26, 2020
Merged

Bug 1798571: [release-4.4] Make ObjectBucket & ObjectBucketClaim CRs owned and hide their APIs #460

merged 8 commits into from
Mar 26, 2020

Conversation

obnoxxx
Copy link
Contributor

@obnoxxx obnoxxx commented Mar 26, 2020 •
edited
Loading

This backports prs #424 and #438 to release-4.4.

@umangachapagain @obnoxxx
bump OCS version to 4.4.0
cb1a987 
Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
(cherry picked from commit 75eca2d)
@openshift-ci-robot
Copy link

@obnoxxx: This pull request references Bugzilla bug 1798571, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "OCS 4.4.0" instead
  • expected Bugzilla bug 1798571 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1798571: [release-4.4] Hide ObjectBuckets & ObjectBucketClaims APIs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 26, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@obnoxxx
Copy link
Contributor Author

obnoxxx commented Mar 26, 2020

This is rebased on top of PR #459 in order to be able to generate the correct CSV.

@obnoxxx obnoxxx added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 26, 2020
@obnoxxx
Copy link
Contributor Author

obnoxxx commented Mar 26, 2020 •
edited
Loading

/hold

waiting for #459 and #458

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
umangachapagain and others added 2 commits March 26, 2020 01:40
@umangachapagain @obnoxxx
update package manifest to include OCS v4.4.0
821d96f 
Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
(cherry picked from commit c9375e8)
@obnoxxx
Generate latest CSV for 4.4.0
ce6b9f0 
Signed-off-by: Michael Adam <obnox@redhat.com>
@obnoxxx obnoxxx force-pushed the release-4.4-backport-pr-438 branch from 70db415 to 58fce4b Compare March 26, 2020 00:50
jackyalbo and others added 5 commits March 26, 2020 02:01
@jackyalbo @obnoxxx
ob and obc will move to owned insted of required
4a8eb68 
As part of not being dependent on community operators BZ1798571

Signed-off-by: jackyalbo <jalbo@redhat.com>
(cherry picked from commit 1f20df5)
@obnoxxx
Update CSV.
27d6946 
Signed-off-by: Michael Adam <obnox@redhat.com>
@jackyalbo @obnoxxx
updating go.sum
371b502 
Signed-off-by: jackyalbo <jalbo@redhat.com>
(cherry picked from commit e8dfc33)
@umangachapagain @obnoxxx
hide ObjectBuckets and ObjectBucketClaims APIs
94cf129 
adds objectbuckets and objectbucketclaims CRDs to the list
of internal objects in annotations.

Signed-off-by: Umanga Chapagain <chapagainumanga@gmail.com>
(cherry picked from commit 619ffa4)
@obnoxxx
Update CSV.
b95a16d 
Signed-off-by: Michael Adam <obnox@redhat.com>
@obnoxxx obnoxxx force-pushed the release-4.4-backport-pr-438 branch from 58fce4b to b95a16d Compare March 26, 2020 01:04
@obnoxxx
Copy link
Contributor Author

obnoxxx commented Mar 26, 2020

incorporated PR #458 into this one

@obnoxxx obnoxxx changed the title Bug 1798571: [release-4.4] Hide ObjectBuckets & ObjectBucketClaims APIs Bug 1798571: [release-4.4] Make ObjectBucket & ObjectBucketClaim CRs owned and hide their APIs Mar 26, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Mar 26, 2020
@openshift-ci-robot
Copy link

@obnoxxx: This pull request references Bugzilla bug 1798571, which is invalid:

  • expected the bug to target the "4.4.0" release, but it targets "OCS 4.4.0" instead
  • expected Bugzilla bug 1798571 to depend on a bug targeting the "4.5.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1798571: [release-4.4] Make ObjectBucket & ObjectBucketClaim CRs owned and hide their APIs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@obnoxxx obnoxxx added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 26, 2020
@obnoxxx obnoxxx mentioned this pull request Mar 26, 2020
Closed
@obnoxxx
Copy link
Contributor Author

obnoxxx commented Mar 26, 2020

/hold cancel

since this is based on 459

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
jarrpa
jarrpa approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa, obnoxxx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@jarrpa jarrpa merged commit d11e49c into red-hat-storage:release-4.4 Mar 26, 2020
@openshift-ci-robot
Copy link

@obnoxxx: All pull requests linked via external trackers have merged: openshift/ocs-operator#424, openshift/ocs-operator#460. Bugzilla bug 1798571 has been moved to the POST state.

In response to this:

Bug 1798571: [release-4.4] Make ObjectBucket & ObjectBucketClaim CRs owned and hide their APIs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jun 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrpa jarrpa jarrpa approved these changes

@davidvossel davidvossel Awaiting requested review from davidvossel

Assignees

@jarrpa jarrpa

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@obnoxxx @openshift-ci-robot @openshift-bot @jarrpa @umangachapagain @jackyalbo