Skip to content

Quickfix: revive legacyscheme #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2019
Merged

Quickfix: revive legacyscheme #6

merged 1 commit into from
Jul 19, 2019

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jul 19, 2019

There are event recorders (template, apps, maybe others) which use the encoder from the legacy scheme. This is wrong: since openshift-apiserver is separate the types are not in that scheme anymore and should not be.

This PR is a quickfix against the CI fires. It should be reverted and all references to legacy scheme should be removed.

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 19, 2019
tnozicka
tnozicka approved these changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as stated to unblock ci now, the scheme should be fixed when we are not on fire
/lgtm
/approve

cmd/openshift-controller-manager/main.go
@@ -10,16 +10,42 @@ import (

"github.com/spf13/cobra"
"github.com/spf13/pflag"

utilruntime "k8s.io/apimachinery/pkg/util/runtime"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: \n

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2019
@tnozicka tnozicka added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2019
@sttts
Copy link
Contributor Author

sttts commented Jul 19, 2019

/cc @bparees @adambkaplan

@tnozicka tnozicka mentioned this pull request Jul 19, 2019
Merged
@sttts
Copy link
Contributor Author

sttts commented Jul 19, 2019

/retest

@deads2k
Copy link
Contributor

deads2k commented Jul 19, 2019

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: deads2k, sttts, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor

deads2k commented Jul 19, 2019

I think the DC failures are probably because the first set of oc images from openshift/oc got promoted. Merging this to move us a little further forward.

@deads2k deads2k merged commit bbf3bba into openshift:master Jul 19, 2019
@openshift-ci-robot
Copy link
Contributor

@sttts: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 8471425 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
@openshift-merge-robot
Merge pull request openshift#6 from juanvallejo/add-manifests-dir
43e6651 
update to flat updatepayload structure
openshift-merge-robot pushed a commit that referenced this pull request Sep 17, 2024
@openshift-merge-bot
Merge pull request #6 from adambkaplan/cve-2024-45496-4.15
6067081 
[release-4.15] CVE-2024-45496: Reduce Capabilities for Non-Build Containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@bparees bparees Awaiting requested review from bparees

1 more reviewer

@tnozicka tnozicka tnozicka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@deads2k deads2k

@tnozicka tnozicka

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sttts @deads2k @openshift-ci-robot @tnozicka