Skip to content

[RHACS] [Docs] ROX-30849: Docs for configuring the EHLO/HELO hostname for SMTP notifiers #100004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: rhacs-docs-main
Choose a base branch
from
Open

[RHACS] [Docs] ROX-30849: Docs for configuring the EHLO/HELO hostname for SMTP notifiers #100004

wants to merge 1 commit into from
+3 −1

Conversation

agantony
Copy link
Contributor

@agantony agantony commented Oct 3, 2025 •
edited
Loading

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/ROX-30849

Link to docs preview:
https://100004--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-email.html

SME review:

  • SME has approved this change.

Additional information:

  • Cherry-pick to rhacs-docs-4.9

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-30849 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/ROX-30849

Link to docs preview:

SME review:

  • SME has approved this change.

Additional information:

  • Cherry-pick to rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agantony agantony added RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.9 labels Oct 3, 2025
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 3, 2025
clickboo
clickboo reviewed Oct 3, 2025
View reviewed changes
clickboo
clickboo reviewed Oct 3, 2025
View reviewed changes
Copy link

@clickboo clickboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 3, 2025 •
edited
Loading

🤖 Fri Oct 10 15:39:53 - Prow CI generated the docs preview:

https://100004--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-email.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-30849 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/ROX-30849

Link to docs preview:
https://100004--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-email.html

SME review:

  • SME has approved this change.

Additional information:

  • Cherry-pick to rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

kcarmichael08
kcarmichael08 reviewed Oct 3, 2025
View reviewed changes
Copy link
Contributor

@kcarmichael08 kcarmichael08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than Khushboo's suggestion which I +1, one other thing noted.

@kcarmichael08 kcarmichael08 added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 3, 2025
@agantony agantony force-pushed the ROX30849-rhacs-docs-main branch from 7fe93cd to ae64ef8 Compare October 10, 2025 14:54
@agantony agantony requested a review from clickboo October 10, 2025 14:54
clickboo
clickboo reviewed Oct 10, 2025
View reviewed changes
clickboo
clickboo approved these changes Oct 10, 2025
View reviewed changes
Copy link

@clickboo clickboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, lgtm otherwise

ROX30849 Docs for configuring the EHLO/HELO hostname for SMTP notifiers
f0f4624 
ROX30849 Review comments

ROX30849 Review comments
@agantony agantony force-pushed the ROX30849-rhacs-docs-main branch from ae64ef8 to f0f4624 Compare October 10, 2025 15:26
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 10, 2025 •
edited by openshift-ci bot
Loading

@agantony: This pull request references ROX-30849 which is a valid jira issue.

In response to this:

Version(s):
4.9+

Issue:
https://issues.redhat.com/browse/ROX-30849

Link to docs preview:
https://100004--ocpdocs-pr.netlify.app/openshift-acs/latest/integration/integrate-with-email.html

SME review:

  • SME has approved this change.

Additional information:

  • Cherry-pick to rhacs-docs-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 10, 2025

@agantony: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kcarmichael08 kcarmichael08 kcarmichael08 left review comments

+1 more reviewer

@clickboo clickboo clickboo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR RHACS Label for RHACS related PRs that go in the rhacs-docs branch rhacs-docs-4.9 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@agantony @openshift-ci-robot @ocpdocs-previewbot @clickboo @kcarmichael08