Skip to content

OSDOCS-15543#Improved environment variable parsing for ImagePaths #100338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OSDOCS-15543#Improved environment variable parsing for ImagePaths #100338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions modules/oc-mirror-imageset-config-parameters-v2.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,12 @@ repositories:
====
`oc-mirror` detects and mirrors container images from the helm chart by searching well-known paths. You can also specify custom paths using this field.
====
|Array of string. For example: `"- {.spec.template.spec.custom[*].image}"`.
+
[NOTE]
====
Operand images, dynamically deployed by operator controllers at runtime, are typically referenced by environment variables within the controller's Deployment template. Before {product-title} 4.20, while `oc-mirror` could access these environment variables, it attempted to mirror all values, including non-image references, for example, log levels, leading to failures. Now {product-title} identifies and mirrors only the container images referenced in these environment variables.
====
|Array of string. For example: `"- {.spec.template.spec.custom[*].image}"`.
endif::microshift[]

|`mirror.operators`
Expand Down Expand Up @@ -508,4 +513,4 @@ The default is `ocp`
|Boolean
The default value is `false`
endif::microshift[]
|===
|===