Skip to content

Rm disabling featuregate info #15276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2019
Merged

Rm disabling featuregate info #15276

merged 1 commit into from
Jun 10, 2019

Conversation

adellape
Copy link
Contributor

@adellape adellape added this to the Next Release milestone Jun 10, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 10, 2019
deads2k
deads2k reviewed Jun 10, 2019
View reviewed changes
modules/nodes-cluster-features-about.adoc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very important. I'm not super familiar with the doc layout, but is there a way to put a gold star on this or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there's an [IMPORTANT] admonition around similar during the procedure itself below, but I'll add it to this block here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now it appears at the beginning of the [IMPORTANT] block that was right next to it re: support scope:

http://file.rdu.redhat.com/~adellape/061019/oneway_featuregate/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-features-about_nodes-cluster-enabling

@deads2k
Copy link
Contributor

deads2k commented Jun 10, 2019

lgtm

@adellape adellape force-pushed the oneway_featuregate branch from 2df598f to be53fd8 Compare June 10, 2019 13:11
@adellape adellape merged commit fa99357 into openshift:master Jun 10, 2019
@adellape
Copy link
Contributor Author

/cherrypick enterprise-4.1

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 10, 2019
Merged
@openshift-cherrypick-robot
Copy link

@adellape: new pull request created: #15278

In response to this:

/cherrypick enterprise-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-redhat
Copy link
Contributor

vikram-redhat commented Jul 26, 2019 •
edited
Loading

@adellape only for 4.1? I have done this for 4.2 via this: #16030 as part of some other changes, but feel free undo this specific part if not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k deads2k left review comments

Assignees

No one assigned

Labels

branch/enterprise-4.1 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@adellape @deads2k @openshift-cherrypick-robot @vikram-redhat @openshift-ci-robot