Skip to content

bz 1790533: CNV Operator name update for 4.3 #19317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

bz 1790533: CNV Operator name update for 4.3 #19317

merged 1 commit into from
Jan 30, 2020

Conversation

ousleyp
Copy link
Member

@ousleyp ousleyp commented Jan 25, 2020

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 25, 2020
@ousleyp ousleyp removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 25, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 25, 2020
@openshift-docs-preview-bot
Copy link

The preview will be available shortly at:

@ousleyp ousleyp force-pushed the operator-name-2.2 branch 2 times, most recently from ddddcc0 to 6720b40 Compare January 25, 2020 21:30
@ousleyp ousleyp changed the title [WIP] Bug 1790533: CNV Operator name update for 4.3 bz 1790533: CNV Operator name update for 4.3 Jan 25, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 25, 2020
@openshift openshift deleted a comment from openshift-ci-robot Jan 25, 2020
@ousleyp
Copy link
Member Author

ousleyp commented Jan 25, 2020

@alexxa Hi Irina, will you please test this for 2.2? I tested it on a 4.3 cluster but I suspect that the version that I have isn't completely up to date for a few reasons:

  • @tiraboschi said that the "Operator" part of the name is being removed for 2.2, but it was still there. Let me know if I should add it back in.
  • The update channel was still 2.1
  • I also am not sure if the name of the CR is supposed to be "kubevirt-hyperconverged" (which is what I saw in the UI) or "hyperconverged-cluster" (how it currently is in this draft)

Let me know if you have any questions or concerns! Thanks :)

@dankenigsberg dankenigsberg mentioned this pull request Jan 26, 2020
Closed
@ousleyp ousleyp force-pushed the operator-name-2.2 branch 5 times, most recently from f0a295c to 03891bb Compare January 28, 2020 20:31
@ousleyp ousleyp added branch/enterprise-4.3 branch/enterprise-4.4 peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 28, 2020
@ousleyp ousleyp added this to the Next Release milestone Jan 28, 2020
@ousleyp ousleyp requested a review from alexxa January 28, 2020 20:51
kalexand-rh
kalexand-rh reviewed Jan 29, 2020
View reviewed changes
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jan 29, 2020
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2020
nellyc
nellyc reviewed Jan 30, 2020
View reviewed changes
modules/cnv-deleting-custom-resource.adoc Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{CNVProductNameStart} instead of kubevirt-hyperconverged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nellyc The custom resource itself is called kubevirt-hyperconverged in the most recent screenshot I received from @alexxa (under "Hyper Convergeds")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From @alexxa: according to CNV CSV 2.2 version, line #12, the correct name is kubevirt-hyperconverged

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 30, 2020
@ousleyp ousleyp merged commit 415843e into openshift:master Jan 30, 2020
@ousleyp
Copy link
Member Author

ousleyp commented Jan 30, 2020

/cherrypick enterprise-4.3

@ousleyp
Copy link
Member Author

ousleyp commented Jan 30, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 30, 2020
Merged
@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #19407

In response to this:

/cherrypick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 30, 2020
Merged
@openshift-cherrypick-robot
Copy link

@ousleyp: new pull request created: #19408

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexxa
Copy link

alexxa commented Jan 30, 2020

@nellyc hyperconverged-cluster comes from the scripts qe (and maybe dev) use. CSV line 12, contains kubevirt-hyperconverged name (doubled checked with Simone today), and when a user opens default yaml to create a CR, they will see kubevirt-hyperconverged. They may change it to whatever they want.
image

@ousleyp ousleyp deleted the operator-name-2.2 branch March 3, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalexand-rh kalexand-rh kalexand-rh left review comments

@alexxa alexxa Awaiting requested review from alexxa

+1 more reviewer

@nellyc nellyc nellyc left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.3 branch/enterprise-4.4 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

8 participants

@ousleyp @openshift-docs-preview-bot @openshift-cherrypick-robot @alexxa @nellyc @kalexand-rh @openshift-ci-robot @dankenigsberg