Skip to content

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Jul 10, 2020

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 10, 2020
@openshift-docs-preview-bot

The preview will be available shortly at:

@neal-timpe
Copy link
Contributor Author

@objectiser can you take a look?

@neal-timpe neal-timpe requested a review from tvieira July 20, 2020 20:35
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 21, 2020
@neal-timpe neal-timpe requested a review from knrc July 21, 2020 22:10
@neal-timpe neal-timpe requested a review from gbaufake July 22, 2020 15:46
@knrc
Copy link

knrc commented Jul 22, 2020

lgtm

Copy link

@gbaufake gbaufake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Panic in the kubernetesenv when the Controller is not set on owner reference. If a pod has an ownerReference which does not specify a Controller this will cause a panic within the kubernetesenv cache.go code. (Unsure about the capitalization of Controller here, but it should be consistent.)

@JStickler JStickler merged commit c302ecc into openshift:master Jul 22, 2020
@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.3

@openshift-cherrypick-robot

@JStickler: new pull request created: #24088

In response to this:

/cherry-pick enterprise-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.4

@openshift-cherrypick-robot

@JStickler: new pull request created: #24089

In response to this:

/cherry-pick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.5

@openshift-cherrypick-robot

@JStickler: new pull request created: #24091

In response to this:

/cherry-pick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JStickler
Copy link
Contributor

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot

@JStickler: new pull request created: #24092

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the ossm115rn branch July 28, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants