RN-OpenShift Virtualization 2.5 Release Notes #26232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
sjhala-ccs
force-pushed
the
cnv-2.5-release-notes
branch
2 times, most recently
from
c1d1718 to
165f4c2
Compare
|
The preview will be available shortly at: |
virt/virt-2-4-release-notes.adoc
Outdated
There was a problem hiding this comment.
Which reminds me, we should add a dummy 2.5 file in the master branch
There was a problem hiding this comment.
PR to add the dummy 2.5 file: #26245
virt/virt-2-5-release-notes.adoc
Outdated
There was a problem hiding this comment.
We can uncomment this include now.
It might also be worthwhile removing the first sentence in L9 since it's redundant (and this module uses version attribute so won't run into maintenance issues) but let's see how it looks for now. It might not be a bad thing to repeat.
sjhala-ccs
force-pushed
the
cnv-2.5-release-notes
branch
from
165f4c2 to
e7c2044
Compare
sjhala-ccs
force-pushed
the
cnv-2.5-release-notes
branch
from
e7c2044 to
39352a3
Compare
|
/lgtm |
| Red Hat {VirtProductName} {VirtVersion} is supported for use on {product-title} 4.6 clusters. {VirtProductName} enables you to bring traditional virtual machines (VMs) into {product-title} where they run alongside containers, and are managed as native Kubernetes objects. | ||
|
|
||
| //Branding-Logo | ||
| {VirtProductName} is represented by the image:Operator_Icon-OpenShift_Virtualization-5.png[{VirtProductName}] logo. |
There was a problem hiding this comment.
@sjhala-ccs @aburdenthehand - this image doesn't exist. Can you add this image or remove this line?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft of the 2.5 release notes
Please note that the virt-2-4-release-notes.adoc file did not have any content so I had rewrite it using
git checkout enterprise-4.5 virt-2-4-release-notes.adocbefore cloning it.Also added a missing module virt-supported-cluster-version.adoc