6109-3scaleIstioServiceMesh2 - Added updates for 3scale Istio Adapter in Service Mesh 2.0 #26279

dfennessy · 2020-10-09T13:08:15Z

This pull requested is based on THREESCALE-6109

Reviewers

unleashed

Looks good to me, just a couple of suggestions.

modules/threescale-backend-cache.adoc

modules/ossm-threescale-integrate.adoc

modules/threescale-backend-cache.adoc

neal-timpe · 2020-10-15T12:57:40Z

@dfennessy I'll add some reviewers. I noticed the build failure. The link xref:../../service_mesh/v2x/installing-ossm.adoc#ossm-control-plane-deploy-1x_installing-ossm-v1x[Deploying the Red Hat OpenShift Service Mesh control plane] should be xref:../../service_mesh/v2x/installing-ossm.adoc#ossm-control-plane-deploy_installing-ossm.

modules/ossm-threescale-integrate.adoc

modules/threescale-backend-cache.adoc

modules/cluster-logging-log-forward-update.adoc

brian-avery · 2020-10-15T21:51:07Z

LGTM. A couple of minor comments.

modules/threescale-istio-adapter-apicast.adoc

JStickler · 2020-10-23T20:15:44Z

modules/ossm-cr-threescale-1x.adoc

It looks like there are two versions of this file, so the "include" note needs to be updated that this one only applies to OSSM v1x.

Ok, I just removed the second of these comments (on line 4) in my recent commit.

JStickler · 2020-10-23T20:17:09Z

modules/ossm-cr-threescale.adoc

Line 4 - Since there are now two versions of this file, the "include" note needs to be updated that this one only applies to OSSM v2x.

JStickler · 2020-10-23T20:29:00Z

modules/threescale-backend-cache.adoc

This looks like a new module.
1 - Do you want to change the file name to ossm-threescale-backend-cache so that the file shows up in the list with your other files?
2 - Since this is a new file, it is not included in service_mesh/v1x/threescale_adapter/threescale-adapter.adoc

JStickler · 2020-10-23T20:43:46Z

modules/threescale-backend-cache.adoc

This is a hard link to a version of the docs that does NOT include these parameters.

I think what you want here is an XREF to the file that will include the example with these new parameters.
The format is: xref:<relative_path_including_OSSM_version/<assembly_file_name>#underscore< context> [linktext]
so,
xref:../../service_mesh/v2x/threescale-adapter.adoc#ossm-cr-threescale_threescale-adapter[Example 3scale configuration options].

This XREF must be fixed before this PR can be merged. (my other commends are "nice to have")

I changed the link to use the form of XREF that you recommended here. But I was not able to check the link locally, as I am not familiar with the build process for this document.

JStickler · 2020-10-23T20:45:31Z

modules/threescale-istio-adapter-apicast.adoc

This looks like a new module.
1 - Do you want to change the file name to ossm-threescale-itstio-adapter-apicast so that the file shows up in the list with your other files?
2 - Since this is a new file, it is not included in service_mesh/v1x/threescale_adapter/threescale-adapter.adoc

unleashed

This needs changes in the text talking about OIDC - @pehala will provide a PR upstream we can incorporate here. /cc @dfennessy

Edit: here's the PR 3scale/3scale-istio-adapter#177

fbolton · 2020-10-29T21:39:14Z

@unleashed Ok, I just made the corresponding updates to the modules/ossm-threescale-authentication.adoc file based on Petr Hala's updates to the README file. Can you check if this looks Ok?

unleashed

Looks good @fbolton

… in Service Mesh 2.0

fbolton · 2020-10-30T11:17:58Z

@neal-timpe I just squashed the commits. I think we are ready to merge this PR now.

JStickler · 2020-10-30T14:54:19Z

/cherry-pick enterprise-4.6

openshift-cherrypick-robot · 2020-10-30T14:54:34Z

@JStickler: new pull request created: #26935

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

JStickler · 2020-10-30T14:56:32Z

/cherry-pick enterprise-4.7

openshift-cherrypick-robot · 2020-10-30T14:56:42Z

@JStickler: new pull request created: #26936

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vikram-redhat · 2021-02-17T06:29:47Z

@JStickler or @neal-timpe Can you please remove the xrefs in the modules introduced by this PR?

https://github.com/openshift/openshift-docs/pull/26279/files#diff-51ca23ec675b3565648b1405ce4eff77fed56cd51edec24545157c1ba8b4c250R22
https://github.com/openshift/openshift-docs/pull/26279/files#diff-1bd8cfef8046278f5ccb4b56297611ec5fd59e14abf6d44b1fbe6ec284a1db0bR41

https://github.com/openshift/openshift-docs/pull/26736/files#diff-a6d41e33bca0f3ad39440f180bd2a48e982e0d519872560e51217c34737168f0R29 (another PR).

Our guidance on this hasn't changed: https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc#links-hyperlinks-and-cross-references

openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 9, 2020

neal-timpe self-requested a review October 9, 2020 13:52

unleashed approved these changes Oct 13, 2020

View reviewed changes

modules/threescale-backend-cache.adoc Outdated Show resolved Hide resolved

modules/threescale-backend-cache.adoc Outdated Show resolved Hide resolved

dfennessy force-pushed the 6109-3scaleIstioServiceMesh2 branch from b74cd90 to 579ae03 Compare October 13, 2020 16:17

unleashed reviewed Oct 13, 2020

View reviewed changes

modules/ossm-threescale-integrate.adoc Outdated Show resolved Hide resolved

modules/threescale-backend-cache.adoc Outdated Show resolved Hide resolved

dfennessy force-pushed the 6109-3scaleIstioServiceMesh2 branch from 579ae03 to 51f70f2 Compare October 14, 2020 16:35

neal-timpe requested review from gbaufake and brian-avery October 15, 2020 12:59

neal-timpe suggested changes Oct 15, 2020

View reviewed changes

modules/ossm-threescale-integrate.adoc Outdated Show resolved Hide resolved

brian-avery reviewed Oct 15, 2020

View reviewed changes

modules/threescale-backend-cache.adoc Outdated Show resolved Hide resolved

brian-avery reviewed Oct 15, 2020

View reviewed changes

modules/cluster-logging-log-forward-update.adoc Outdated Show resolved Hide resolved

dfennessy force-pushed the 6109-3scaleIstioServiceMesh2 branch 3 times, most recently from b86eed9 to 3acdd49 Compare October 22, 2020 15:41

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 22, 2020

neal-timpe reviewed Oct 22, 2020

View reviewed changes

modules/threescale-istio-adapter-apicast.adoc Show resolved Hide resolved

fbolton force-pushed the 6109-3scaleIstioServiceMesh2 branch from 14a58c3 to 91a6c7b Compare October 23, 2020 14:49

neal-timpe approved these changes Oct 23, 2020

View reviewed changes

JStickler reviewed Oct 23, 2020

View reviewed changes

gbaufake approved these changes Oct 27, 2020

View reviewed changes

unleashed suggested changes Oct 29, 2020

View reviewed changes

unleashed approved these changes Oct 29, 2020

View reviewed changes

6109-3scaleIstioServiceMesh2 - Added updates for 3scale Istio Adapter…

485ed96

… in Service Mesh 2.0

fbolton force-pushed the 6109-3scaleIstioServiceMesh2 branch from 2397d4f to 485ed96 Compare October 30, 2020 11:16

neal-timpe approved these changes Oct 30, 2020

View reviewed changes

JStickler approved these changes Oct 30, 2020

View reviewed changes

JStickler merged commit 413afab into openshift:master Oct 30, 2020

openshift-cherrypick-robot mentioned this pull request Oct 30, 2020

[enterprise-4.6] 6109-3scaleIstioServiceMesh2 - Added updates for 3scale Istio Adapter in Service Mesh 2.0 #26935

Merged

openshift-cherrypick-robot mentioned this pull request Oct 30, 2020

[enterprise-4.7] 6109-3scaleIstioServiceMesh2 - Added updates for 3scale Istio Adapter in Service Mesh 2.0 #26936

Merged

6109-3scaleIstioServiceMesh2 - Added updates for 3scale Istio Adapter in Service Mesh 2.0 #26279

6109-3scaleIstioServiceMesh2 - Added updates for 3scale Istio Adapter in Service Mesh 2.0 #26279

Uh oh!

Conversation

dfennessy commented Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

unleashed left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neal-timpe commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

brian-avery commented Oct 15, 2020

Uh oh!

Uh oh!

JStickler Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

fbolton Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

JStickler Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

JStickler Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

JStickler Oct 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JStickler Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

fbolton Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

JStickler Oct 23, 2020

Choose a reason for hiding this comment

Uh oh!

unleashed left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fbolton commented Oct 29, 2020

Uh oh!

unleashed left a comment

Choose a reason for hiding this comment

Uh oh!

fbolton commented Oct 30, 2020

Uh oh!

JStickler commented Oct 30, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Oct 30, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JStickler commented Oct 30, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Oct 30, 2020 • edited by openshift-ci-robot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vikram-redhat commented Feb 17, 2021

Uh oh!

Uh oh!

dfennessy commented Oct 9, 2020 •

edited

Loading

neal-timpe commented Oct 15, 2020 •

edited

Loading

JStickler Oct 23, 2020 •

edited

Loading

unleashed left a comment •

edited

Loading

JStickler commented Oct 30, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Oct 30, 2020 •

edited by openshift-ci-robot

Loading

JStickler commented Oct 30, 2020 •

edited by openshift-ci-robot

Loading

openshift-cherrypick-robot commented Oct 30, 2020 •

edited by openshift-ci-robot

Loading