Skip to content

Conversation

bergerhoffer
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2020
@bergerhoffer bergerhoffer added this to the Next Release milestone Nov 18, 2020
@openshift-docs-preview-bot
Copy link

openshift-docs-preview-bot commented Nov 18, 2020

jboxman
jboxman previously requested changes Dec 3, 2020
Copy link
Contributor

@jboxman jboxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments for your review. Thanks!

@jboxman jboxman added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 3, 2020
@bergerhoffer bergerhoffer force-pushed the term-updates-security-2 branch 2 times, most recently from 6531f57 to 6da4252 Compare December 3, 2020 19:20
@bergerhoffer bergerhoffer force-pushed the term-updates-security-2 branch from 6da4252 to ad4eb8e Compare December 3, 2020 19:34
@bergerhoffer bergerhoffer dismissed jboxman’s stale review December 3, 2020 19:41

Feedback incorporated

@bergerhoffer bergerhoffer merged commit 3b31dce into openshift:master Dec 3, 2020
@bergerhoffer bergerhoffer deleted the term-updates-security-2 branch December 3, 2020 19:54
@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 3, 2020

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 3, 2020

/cherrypick enterprise-4.6

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 3, 2020

/cherrypick enterprise-4.5

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 3, 2020

@bergerhoffer: new pull request created: #27839

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bergerhoffer
Copy link
Contributor Author

bergerhoffer commented Dec 3, 2020

/cherrypick enterprise-4.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 3, 2020

@bergerhoffer: new pull request created: #27840

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 3, 2020

@bergerhoffer: #27486 failed to apply on top of branch "enterprise-4.4":

Applying: Terminology style updates for the rest of the security book
Using index info to reconstruct a base tree...
M	modules/about-etcd-encryption.adoc
M	modules/auth-allowing-javascript-access-api-server.adoc
M	modules/builds-adding-input-secrets-configmaps.adoc
M	modules/builds-input-secrets-configmaps.adoc
M	modules/customize-certificates-add-service-serving-apiservice.adoc
M	modules/customize-certificates-add-service-serving-configmap.adoc
M	modules/customize-certificates-add-service-serving-crd.adoc
M	modules/customize-certificates-add-service-serving-mutating-webhook.adoc
M	modules/customize-certificates-add-service-serving-validating-webhook.adoc
M	modules/customize-certificates-add-service-serving.adoc
M	modules/customize-certificates-replace-default-router.adoc
M	modules/customize-certificates-rotate-service-serving.adoc
M	modules/disabling-etcd-encryption.adoc
M	modules/enabling-etcd-encryption.adoc
M	modules/security-build-inputs.adoc
M	modules/security-monitoring-events.adoc
A	security/certificate_types_descriptions/ingress-certificates.adoc
A	security/certificate_types_descriptions/proxy-certificates.adoc
A	security/certificate_types_descriptions/service-ca-certificates.adoc
A	security/certificate_types_descriptions/user-provided-certificates-for-default-ingress.adoc
M	security/container_security/security-platform.adoc
Falling back to patching base and 3-way merge...
Auto-merging security/container_security/security-platform.adoc
CONFLICT (modify/delete): security/certificate_types_descriptions/user-provided-certificates-for-default-ingress.adoc deleted in HEAD and modified in Terminology style updates for the rest of the security book. Version Terminology style updates for the rest of the security book of security/certificate_types_descriptions/user-provided-certificates-for-default-ingress.adoc left in tree.
CONFLICT (modify/delete): security/certificate_types_descriptions/service-ca-certificates.adoc deleted in HEAD and modified in Terminology style updates for the rest of the security book. Version Terminology style updates for the rest of the security book of security/certificate_types_descriptions/service-ca-certificates.adoc left in tree.
CONFLICT (modify/delete): security/certificate_types_descriptions/ingress-certificates.adoc deleted in HEAD and modified in Terminology style updates for the rest of the security book. Version Terminology style updates for the rest of the security book of security/certificate_types_descriptions/ingress-certificates.adoc left in tree.
Auto-merging modules/security-monitoring-events.adoc
Auto-merging modules/security-build-inputs.adoc
CONFLICT (content): Merge conflict in modules/security-build-inputs.adoc
Auto-merging modules/proxy-certificates.adoc
CONFLICT (content): Merge conflict in modules/proxy-certificates.adoc
Auto-merging modules/enabling-etcd-encryption.adoc
Auto-merging modules/disabling-etcd-encryption.adoc
Auto-merging modules/customize-certificates-rotate-service-serving.adoc
CONFLICT (content): Merge conflict in modules/customize-certificates-rotate-service-serving.adoc
Auto-merging modules/customize-certificates-replace-default-router.adoc
Auto-merging modules/customize-certificates-add-service-serving.adoc
Auto-merging modules/customize-certificates-add-service-serving-validating-webhook.adoc
Auto-merging modules/customize-certificates-add-service-serving-mutating-webhook.adoc
Auto-merging modules/customize-certificates-add-service-serving-crd.adoc
Auto-merging modules/customize-certificates-add-service-serving-configmap.adoc
Auto-merging modules/customize-certificates-add-service-serving-apiservice.adoc
Auto-merging modules/builds-input-secrets-configmaps.adoc
CONFLICT (content): Merge conflict in modules/builds-input-secrets-configmaps.adoc
Auto-merging modules/builds-adding-input-secrets-configmaps.adoc
CONFLICT (content): Merge conflict in modules/builds-adding-input-secrets-configmaps.adoc
Auto-merging modules/auth-allowing-javascript-access-api-server.adoc
Auto-merging modules/about-etcd-encryption.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Terminology style updates for the rest of the security book
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Dec 3, 2020

@bergerhoffer: new pull request created: #27841

In response to this:

/cherrypick enterprise-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.4 branch/enterprise-4.5 branch/enterprise-4.6 branch/enterprise-4.7 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants