Skip to content

6537-BrokenLink3scaleDocs: Updating broken link. #28259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2021
Merged

6537-BrokenLink3scaleDocs: Updating broken link. #28259

merged 1 commit into from
Jan 13, 2021

Conversation

dfennessy
Copy link
Contributor

@dfennessy dfennessy commented Dec 21, 2020 •
edited by openshift-ci-robot
Loading

This pull requested is based on THREESCALE-6109

Reviewers

@brian-avery
@neal-timpe

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2020
@dfennessy
Copy link
Contributor Author

Thanks for the approval @brian-avery

Happy New Year 🎉

@brian-avery
Copy link
Contributor

You're welcome. Happy New Year to you as well!

neal-timpe
neal-timpe suggested changes Jan 5, 2021
View reviewed changes
modules/ossm-threescale-integrate.adoc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfennessy I don't think you need a link here at all. Also, because this is a module, the published doc doesn't support linking within the content.

But looking at the content, I think that we can just remove the link.

@brian-avery brian-avery mentioned this pull request Jan 11, 2021
Merged
@dfennessy dfennessy force-pushed the 6537-BrokenLink3scaleDocs branch from d9d4993 to 377d6fe Compare January 12, 2021 16:33
@neal-timpe neal-timpe merged commit b43f28a into openshift:master Jan 13, 2021
@neal-timpe
Copy link
Contributor

neal-timpe commented Jan 13, 2021 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.6

@neal-timpe
Copy link
Contributor

neal-timpe commented Jan 13, 2021 •
edited by openshift-ci-robot
Loading

/cherry-pick enterprise-4.7

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 13, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 13, 2021 •
edited by openshift-ci-robot
Loading

@neal-timpe: new pull request created: #28570

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 13, 2021
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 13, 2021 •
edited by openshift-ci-robot
Loading

@neal-timpe: new pull request created: #28571

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@brian-avery brian-avery brian-avery approved these changes

@neal-timpe neal-timpe neal-timpe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
branch/enterprise-4.6 branch/enterprise-4.7 service-mesh Label for all Service Mesh PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dfennessy @brian-avery @neal-timpe @openshift-cherrypick-robot @openshift-ci-robot