Skip to content

[SRVLS][SRVKS-681] Domain mapping for ksvcs #29500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

[SRVLS][SRVKS-681] Domain mapping for ksvcs #29500

merged 1 commit into from
Mar 1, 2021

Conversation

abrennan89
Copy link
Contributor

CP to 4.6, 4.7
Adds domain mapping docs for serverless

/assign @nak3 @markusthoemmes

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2021
@netlify
Copy link

netlify bot commented Feb 15, 2021 •
edited
Loading

Deploy preview for osdocs ready!

Built with commit 6bb0a1b

https://deploy-preview-29500--osdocs.netlify.app

@nak3
Copy link
Contributor

nak3 commented Feb 16, 2021

/lgtm

Thank you!

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2021
@abrennan89 abrennan89 changed the title [WIP][SRVLS][SRVKS-681] Domain mapping for ksvcs [SRVLS][SRVKS-681] Domain mapping for ksvcs Feb 16, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2021
@maschmid
Copy link
Contributor

QE approved

jboxman
jboxman suggested changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@jboxman jboxman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a few comments for your review. Thanks!

@jboxman jboxman added peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs branch/enterprise-4.6 branch/enterprise-4.7 labels Feb 16, 2021
@jboxman jboxman added this to the Next Release milestone Feb 16, 2021
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2021
@nak3
Copy link
Contributor

nak3 commented Feb 25, 2021

@jboxman Friendly ping.

@jboxman jboxman merged commit d6a2d59 into openshift:master Mar 1, 2021
@jboxman
Copy link
Contributor

jboxman commented Mar 1, 2021

/cherry-pick enterprise-4.7

@jboxman
Copy link
Contributor

jboxman commented Mar 1, 2021

/cherry-pick enterprise-4.6

@openshift-cherrypick-robot
Copy link

@jboxman: new pull request created: #29938

In response to this:

/cherry-pick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Mar 1, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jboxman: new pull request created: #29939

In response to this:

/cherry-pick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codyhoag
Copy link
Contributor

codyhoag commented Mar 5, 2021

/cherry-pick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2021
Merged
@openshift-cherrypick-robot
Copy link

@codyhoag: new pull request created: #30163

In response to this:

/cherry-pick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the SRVKS-681 branch December 17, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aburdenthehand aburdenthehand Awaiting requested review from aburdenthehand

@codyhoag codyhoag Awaiting requested review from codyhoag

@jeana-redhat jeana-redhat Awaiting requested review from jeana-redhat

@vikram-redhat vikram-redhat Awaiting requested review from vikram-redhat

2 more reviewers

@nak3 nak3 nak3 left review comments

@jboxman jboxman jboxman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@markusthoemmes markusthoemmes

@nak3 nak3

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

8 participants

@abrennan89 @nak3 @maschmid @openshift-ci-robot @jboxman @openshift-cherrypick-robot @codyhoag @markusthoemmes