Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using URLs with start-build --from-file/--from-dir #3184

Merged
merged 1 commit into from
Nov 28, 2016

Conversation

mmilata
Copy link

@mmilata mmilata commented Nov 9, 2016

Documentation for openshift/origin#11811, please don't merge before that PR is merged.

@@ -333,6 +333,15 @@ one in the build source. For example, *_pom.xml_* or *_Dockerfile_*.
----
$ oc start-build --from-file=<file_name>
----
Download the binary input using http/https instead of reading it from the file
system:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ oc start-build --from-file=<file_url>
----
Download an archive and use its contents as the build source:
----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@@ -1168,6 +1168,15 @@ effectively be ignored and replaced by what the client sends.
disabled, since `*Binary*` and `*Git*` are mutually exclusive, and the data in
the binary stream provided to the builder takes precedence.

Instead of a file name you can pass URL with http or https schema to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma after name

@@ -1168,6 +1168,15 @@ effectively be ignored and replaced by what the client sends.
disabled, since `*Binary*` and `*Git*` are mutually exclusive, and the data in
the binary stream provided to the builder takes precedence.

Instead of a file name you can pass URL with http or https schema to
`--from-file` and `--from-dir`. When using `--from-file` with a URL, the name
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one space between sentences.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, should not happen now with set nojoinspaces in my .vimrc.

@mmilata mmilata changed the title [DoNotMerge] Using URLs with start-build --from-file/--from-dir Using URLs with start-build --from-file/--from-dir Nov 16, 2016
@mmilata
Copy link
Author

mmilata commented Nov 22, 2016

Fixed found issues & updated to match the Origin PR. PTAL @ahardin-rh

@ahardin-rh
Copy link
Contributor

LGTM! I am adding a to_followup label, as I will make a few minor follow-up style edits in a separate PR. Thanks!

@ahardin-rh ahardin-rh merged commit 08d8d3c into openshift:master Nov 28, 2016
@ahardin-rh
Copy link
Contributor

[rev_history]
|xref:../cli_reference/basic_cli_operations.adoc#cli-reference-basic-cli-operations[Developer CLI Operations]
|Added information about oc start-build --from-file and oc start build --from-dir.
%
|xref:../dev_guide/builds.adoc#dev-guide-builds[Builds]
|Added information about using URLS with oc start-build --from-file and oc start build --from-dir.
%

@vikram-redhat vikram-redhat modified the milestones: Staging, OCP 3.5 GA May 2, 2017
@vikram-redhat vikram-redhat modified the milestones: OCP 3.5 GA, Staging, TEMP Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants