-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using URLs with start-build --from-file/--from-dir #3184
Conversation
@@ -333,6 +333,15 @@ one in the build source. For example, *_pom.xml_* or *_Dockerfile_*. | |||
---- | |||
$ oc start-build --from-file=<file_name> | |||
---- | |||
Download the binary input using http/https instead of reading it from the file | |||
system: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include an empty line above the code block per https://github.com/openshift/openshift-docs/blob/master/contributing_to_docs/doc_guidelines.adoc#code-blocks
$ oc start-build --from-file=<file_url> | ||
---- | ||
Download an archive and use its contents as the build source: | ||
---- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
@@ -1168,6 +1168,15 @@ effectively be ignored and replaced by what the client sends. | |||
disabled, since `*Binary*` and `*Git*` are mutually exclusive, and the data in | |||
the binary stream provided to the builder takes precedence. | |||
|
|||
Instead of a file name you can pass URL with http or https schema to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma after name
@@ -1168,6 +1168,15 @@ effectively be ignored and replaced by what the client sends. | |||
disabled, since `*Binary*` and `*Git*` are mutually exclusive, and the data in | |||
the binary stream provided to the builder takes precedence. | |||
|
|||
Instead of a file name you can pass URL with http or https schema to | |||
`--from-file` and `--from-dir`. When using `--from-file` with a URL, the name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one space between sentences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, should not happen now with set nojoinspaces
in my .vimrc.
ac5c4de
to
2cb7947
Compare
Fixed found issues & updated to match the Origin PR. PTAL @ahardin-rh |
LGTM! I am adding a to_followup label, as I will make a few minor follow-up style edits in a separate PR. Thanks! |
[rev_history] |
Documentation for openshift/origin#11811, please don't merge before that PR is merged.