[SRVKS-724] Update serving.knative.dev/visibility to networking.knative.dev/visibility #31862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
|
Deploy preview for osdocs ready! Built with commit 06219ae |
nak3
commented
Apr 23, 2021
There was a problem hiding this comment.
I wrote this but I wonder if this note is not necessary.
The note needs to be removed when serverless v1.15 is released 😅
There was a problem hiding this comment.
Yeah I wouldn't bother adding it for just one release I think, I'd just add the change to release notes and update the label in docs as you have done.
Let's not merge this one until 1.15.0 either if it's not valid until the next release
…ve.dev/visibility
openshift-ci
bot
added
size/XS
|
Closing as 34676c3 covered this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the label to
networking.knative.dev/visibility.Both
networking.knative.dev/visibilityandserving.knative.dev/visibilityare available on serverless v1.14 or before but Serving v0.21+ (serverless v1.15) supports onlynetworking.knative.dev/visibility.Reference: knative/serving@e402e8e
/cc @abrennan89