Skip to content

[srvls][SRVKS-726] Add service mesh support note #32805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 26, 2021
Merged

[srvls][SRVKS-726] Add service mesh support note #32805

merged 1 commit into from
May 26, 2021

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented May 25, 2021 •
edited
Loading

Preview link for main section: https://deploy-preview-32805--osdocs.netlify.app/openshift-enterprise/latest/serverless/networking/serverless-ossm.html
(this note is added in multiple places)

Applies for 4.6+

@abrennan89 abrennan89 added this to the Next Release milestone May 25, 2021
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 25, 2021
@netlify
Copy link

netlify bot commented May 25, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 970e010

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60ae68a60cb3170007f87e60

😎 Browse the preview: https://deploy-preview-32805--osdocs.netlify.app

@abrennan89 abrennan89 changed the title [srvls][SRVKS-726] Add service mesh support note [WIP][srvls][SRVKS-726] Add service mesh support note May 25, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 25, 2021
@abrennan89 abrennan89 changed the title [WIP][srvls][SRVKS-726] Add service mesh support note [srvls][SRVKS-726] Add service mesh support note May 25, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2021
cardil
cardil approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

from QE

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 25, 2021
bergerhoffer
bergerhoffer reviewed May 25, 2021
View reviewed changes
@bergerhoffer
Copy link
Contributor

And as you mentioned in slack, don't forget to squash before merging!

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 26, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 26, 2021

New changes are detected. LGTM label has been removed.

@abrennan89 abrennan89 requested a review from bergerhoffer May 26, 2021 15:26
@bobfuru
Copy link
Contributor

bobfuru commented May 26, 2021

LGTM!

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label May 26, 2021
@abrennan89 abrennan89 merged commit 9d1d11c into openshift:master May 26, 2021
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.6

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 26, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #32864

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 26, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #32865

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 26, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #32866

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the SRVKS-726 branch December 17, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergerhoffer bergerhoffer Awaiting requested review from bergerhoffer

1 more reviewer

@cardil cardil cardil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cardil cardil

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

5 participants

@abrennan89 @bergerhoffer @bobfuru @openshift-cherrypick-robot @cardil