Skip to content

Conversation

ahardin-rh
Copy link
Contributor

@ahardin-rh ahardin-rh commented May 27, 2021

@ahardin-rh ahardin-rh added this to the Future Release milestone May 27, 2021
@ahardin-rh ahardin-rh self-assigned this May 27, 2021
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 27, 2021
@netlify
Copy link

netlify bot commented May 27, 2021

Copy link

@mffiedler mffiedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ahardin-rh ahardin-rh added the peer-review-needed Signifies that the peer review team needs to review this PR label Jun 1, 2021
@jeana-redhat jeana-redhat self-requested a review June 1, 2021 20:28
Copy link
Contributor

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice consolidation :) One small Q from me, but looks good!

influence the stated thresholds, including the etcd version or storage data
format.
These guidelines are based on the largest possible cluster. For smaller clusters, the maximums are lower. There are many factors that
influence the stated thresholds, including the etcd version or storage data format.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you intend to unwrap this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but looks like there's an extra space that's throwing off the flow; fixing that now! Thanks!

@ahardin-rh ahardin-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Jun 1, 2021
@ahardin-rh ahardin-rh merged commit 945740c into openshift:master Jun 1, 2021
@ahardin-rh
Copy link
Contributor Author

/cherrypick enterprise-4.8

@openshift-cherrypick-robot

@ahardin-rh: new pull request created: #32979

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants