Skip to content

OSSMDOC-330: Extensions update #33762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

OSSMDOC-330: Extensions update #33762

merged 1 commit into from
Jun 25, 2021

Conversation

neal-timpe
Copy link
Contributor

@neal-timpe neal-timpe commented Jun 22, 2021 •
edited
Loading

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2021
@netlify
Copy link

netlify bot commented Jun 22, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: daa7f3b8ec2c0204b0c68d890b1917c88e8de096

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d20a9454d0e10008b8f30a

😎 Browse the preview: https://deploy-preview-33762--osdocs.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-extensions

@netlify
Copy link

netlify bot commented Jun 22, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: a9b9e61

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60d62353c59a7b000878779f

😎 Browse the preview: https://deploy-preview-33762--osdocs.netlify.app

@neal-timpe neal-timpe changed the title extensions update OSSMDOC-330: Extensions update Jun 22, 2021
@neal-timpe neal-timpe requested a review from gbaufake June 23, 2021 19:20
yxun
yxun reviewed Jun 24, 2021
View reviewed changes
bmcelvee
bmcelvee reviewed Jun 25, 2021
View reviewed changes
bmcelvee
bmcelvee reviewed Jun 25, 2021
View reviewed changes
bmcelvee
bmcelvee reviewed Jun 25, 2021
View reviewed changes
@bmcelvee
Copy link
Contributor

A few suggestions and a reminder to squash commits, otherwise LGTM!

@bmcelvee bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 25, 2021
@neal-timpe
Copy link
Contributor Author

@bmcelvee Knocked those out too and just squashed. Ready for this one to merge and cp to 4.6-4.8 whenever you get another minute. Thanks for the review and merging the other one!

@bmcelvee bmcelvee merged commit d857427 into openshift:master Jun 25, 2021
@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.6

@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.7

@bmcelvee
Copy link
Contributor

/cherrypick enterprise-4.8

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 25, 2021
Merged
@openshift-cherrypick-robot
Copy link

@bmcelvee: new pull request created: #33998

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bmcelvee: new pull request created: #33999

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 25, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

@bmcelvee: new pull request created: #34000

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neal-timpe neal-timpe deleted the ossmdoc-330 branch July 8, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmcelvee bmcelvee bmcelvee left review comments

@gbaufake gbaufake Awaiting requested review from gbaufake

+2 more reviewers

@knrc knrc knrc approved these changes

@yxun yxun yxun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neal-timpe @bmcelvee @openshift-cherrypick-robot @knrc @yxun