Skip to content

OSSMDOC-354: Fix incorrect link in Release Notes. #33989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2021
Merged

OSSMDOC-354: Fix incorrect link in Release Notes. #33989

merged 1 commit into from
Jun 30, 2021

Conversation

JStickler
Copy link
Contributor

Fixes link to incorrect JIRA in Known Issues section.

@JStickler JStickler requested review from knrc and neal-timpe June 25, 2021 18:17
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2021
@netlify
Copy link

netlify bot commented Jun 25, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: e246fa3

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dcc44e47bd62000799cf60

😎 Browse the preview: https://deploy-preview-33989--osdocs.netlify.app

bergerhoffer
bergerhoffer reviewed Jun 30, 2021
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you also meant to delete the bullet above (in addition to changing the Jira link), then this LGTM

rolfedh
rolfedh reviewed Jun 30, 2021
View reviewed changes
modules/ossm-rn-known-issues.adoc Outdated
Copy link
Contributor

@rolfedh rolfedh Jun 30, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* link:https://issues.jboss.org/browse/MAISTRA-1947[MAISTRA-1947] _Technology Preview_ Updates to ServiceMeshExtensions are not applied. The workaround is to remove and recreate the ServiceMeshExtensions.
* link:https://issues.jboss.org/browse/MAISTRA-1947[MAISTRA-1947] _Technology Preview_ Updates to `ServiceMeshExtensions` are not applied.
+
Workaround: Remove and recreate the `ServiceMeshExtensions`.

rolfedh
rolfedh reviewed Jun 30, 2021
View reviewed changes
modules/ossm-rn-known-issues.adoc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This problem can be addressed by excluding port 15020 from proxy configuration, for example,
Workaround: You can exclude port 15020 from proxy configuration. For example:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suggestion is based on the recently-added "Release Notes" section in the Supplemental Style Guide: https://redhat-documentation.github.io/supplementary-style-guide/#release-notes

@bergerhoffer bergerhoffer added the peer-review-done Signifies that the peer review team has reviewed this PR label Jun 30, 2021
@bergerhoffer bergerhoffer merged commit 7087da2 into openshift:master Jun 30, 2021
@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.8

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.7

@bergerhoffer
Copy link
Contributor

/cherrypick enterprise-4.6

@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #34181

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 30, 2021
Merged
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #34182

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #34183

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 30, 2021
Merged
@JStickler JStickler deleted the OSSMDOC-354 branch December 2, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@knrc knrc Awaiting requested review from knrc

@neal-timpe neal-timpe Awaiting requested review from neal-timpe

+1 more reviewer

@rolfedh rolfedh rolfedh approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JStickler @bergerhoffer @openshift-cherrypick-robot @rolfedh