Skip to content

Conversation

slaskawi
Copy link

@slaskawi slaskawi commented Jun 29, 2021

https://issues.redhat.com/browse/AUTH-13
https://issues.redhat.com/browse/OSDOCS-2366

This Pull Request introduces documentation bits for the Custom hostname and certificate for the oAuth server. It documents openshift/cluster-authentication-operator#430

The documentation has been created based on https://github.com/openshift/openshift-docs/blob/master/modules/customizing-the-web-console-URL.adoc

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 29, 2021
@netlify
Copy link

netlify bot commented Jun 29, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 2231a3f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/60dd6a8ea6e5550007157ddd

😎 Browse the preview: https://deploy-preview-34077--osdocs.netlify.app

@bergerhoffer
Copy link
Contributor

@slaskawi Thanks a lot for opening this! We haven't branched for 4.9 content yet, so I'm going to mark this WIP for now. But once we do, I'll come back and can take over any further editorial updates.

@bergerhoffer bergerhoffer changed the title Custom certs for the oAuth server route [WIP] Custom certs for the oAuth server route Jun 30, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 30, 2021
@bergerhoffer bergerhoffer changed the title [WIP] Custom certs for the oAuth server route [WIP] [enterprise-4.9] Custom certs for the oAuth server route Jun 30, 2021
Copy link

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @slaskawi! We may wish to mention how to review the status of the configured route as well.

@slaskawi slaskawi force-pushed the AUTH-13-custom-certs-for-routes branch from 92206ce to 2231a3f Compare July 1, 2021 07:11
@slaskawi
Copy link
Author

slaskawi commented Jul 1, 2021

Thanks for the review! I addressed all the comments and rebased it.

Thanks a lot for opening this! We haven't branched for 4.9 content yet, so I'm going to mark this WIP for now. But once we do, I'll come back and can take over any further editorial updates.

@bergerhoffer Sure, no problem! Thanks a lot!

@s-urbaniak
Copy link
Contributor

ping @bergerhoffer any chance to merge this?

@bergerhoffer
Copy link
Contributor

ping @bergerhoffer any chance to merge this?

@s-urbaniak We just branched for 4.9 today. I'll go ahead and review this now, and if any updates are needed I can take care of those. Then we'll need QE review, but hopefully shouldn't be too long before we can get this merged.

@bergerhoffer bergerhoffer changed the title [WIP] [enterprise-4.9] Custom certs for the oAuth server route [enterprise-4.9] Custom certs for the oAuth server route Jul 27, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 27, 2021
@bergerhoffer
Copy link
Contributor

Closing this in favor of #34947. I'll tag there for further reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants