Skip to content

Conversation

jeana-redhat
Copy link
Contributor

@jeana-redhat jeana-redhat commented Jul 23, 2021

For https://issues.redhat.com/browse/OSDOCS-2354

Previews:

I was not sure whether an explicit mention is needed here or in Manually creating IAM for Azure. Probably depends on if ASH is covered under Azure more generally, or if it will have its own section.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2021
@netlify
Copy link

netlify bot commented Jul 23, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: aef01b1

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/611156f85f74f50007ba5be9

😎 Browse the preview: https://deploy-preview-34822--osdocs.netlify.app

@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2021
Copy link
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeana-redhat jeana-redhat added the peer-review-needed Signifies that the peer review team needs to review this PR label Aug 9, 2021
@jeana-redhat
Copy link
Contributor Author

@lwan-wanglin Could you please verify from QE perspective?

@lwan-wanglin
Copy link

we haven't started to test installation on ASH yet from qe side, the ASH env is not ready now, so i don't know the manual IAM creation steps too.

but the draft part looks good to me!

Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question!

@bergerhoffer bergerhoffer added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Aug 10, 2021
@jeana-redhat jeana-redhat merged commit 356a215 into openshift:main Aug 10, 2021
@jeana-redhat
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@jeana-redhat: new pull request created: #35389

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@jeana-redhat: new pull request could not be created: failed to create pull request against openshift/openshift-docs#enterprise-4.9 from head openshift-cherrypick-robot:cherry-pick-34822-to-enterprise-4.9: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-34822-to-enterprise-4.9."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants