Skip to content

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Sep 1, 2021

@abrennan89 abrennan89 added this to the Next Release milestone Sep 1, 2021
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2021
@netlify
Copy link

netlify bot commented Sep 1, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 34c7d91

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/614ca717d64bc30008ecd51e

😎 Browse the preview: https://deploy-preview-35989--osdocs.netlify.app

@skonto
Copy link

skonto commented Sep 21, 2021

Unless we want to point to some more docs about emptyDir it lgtm.

@maschmid
Copy link
Contributor

QE approved

@bmcelvee bmcelvee added the peer-review-done Signifies that the peer review team has reviewed this PR label Sep 23, 2021
@bmcelvee
Copy link
Contributor

LGTM! Don't forget to squash your commits :)

A note: the modules in this assembly could be stretched into the procedure module format, though I don't know that it's necessary.

@abrennan89 abrennan89 changed the title [WIP] SRVKS-805: Add emptyDir config SRVKS-805: Add emptyDir config Sep 23, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2021
@abrennan89 abrennan89 merged commit b247dae into openshift:main Sep 23, 2021
@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.6

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor Author

/cherrypick enterprise-4.9

@openshift-cherrypick-robot

@abrennan89: new pull request created: #36706

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #36707

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #36708

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@abrennan89: new pull request created: #36709

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abrennan89 abrennan89 deleted the SRVKS-805 branch December 17, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR serverless Label for all Serverless PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants