Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THREESCALE-7497: Removal of 3scale Istio adapter docs to add 3scale WebAssembly docs. #36249

Merged
merged 1 commit into from
Nov 11, 2021
Merged

THREESCALE-7497: Removal of 3scale Istio adapter docs to add 3scale WebAssembly docs. #36249

merged 1 commit into from
Nov 11, 2021

Conversation

dfennessy
Copy link
Contributor

@dfennessy dfennessy commented Sep 10, 2021 •
edited

This pull requested is based on THREESCALE-7497

Reviewers

Steps

  1. Remove 3scale Istio adapter docs and cross references. Undone removal of the content.
  2. Add new WebAssembly docs

Current link to the preview (may change if the assembly name changes )
https://deploy-preview-36249--osdocs.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-threescale-webassembly-module.html

@openshift-ci openshift-ci bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 10, 2021
@netlify
Copy link

netlify bot commented Sep 10, 2021 •
edited

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 614818d

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/618cff1ce2984800086957f4

😎 Browse the preview: https://deploy-preview-36249--osdocs.netlify.app/openshift-enterprise/latest/service_mesh/v2x/ossm-threescale-webassembly-module

@dfennessy dfennessy force-pushed the THREESCALE-7497 branch 3 times, most recently from 27b2d3e to ce6299c Compare September 10, 2021 11:11
@dfennessy
Copy link
Contributor Author

Finally...success with the build! 🥳

@unleashed unleashed mentioned this pull request Sep 11, 2021
Merged
@JStickler JStickler added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2021
@JStickler
Copy link
Contributor

@dfennessy, we can't just delete all the threescale docs. The v1 docs should remain, and the v2 docs need to be updated, not just yanked out. I've put a DO NOT MERGE tag on this PR.

@dfennessy
Copy link
Contributor Author

@dfennessy, we can't just delete all the threescale docs. The v1 docs should remain, and the v2 docs need to be updated, not just yanked out. I've put a DO NOT MERGE tag on this PR.

Thanks @JStickler

I'll add the docs for the 3scale Istio adapter back and we can work on how we proceed from there.

@unleashed Please advise on how we proceed with the existing 3scale Istio adapter docs for the SM 2.1 release. Cheers.

@unleashed
Copy link

@unleashed Please advise on how we proceed with the existing 3scale Istio adapter docs for the SM 2.1 release. Cheers.

There is no 3scale Istio Adapter on the 2.1 release, so no docs about it either. I think what @JStickler means is that the adapter docs should remain for people working with previous releases, Service Mesh 2.0 and below.

@dfennessy
Copy link
Contributor Author

@unleashed Please advise on how we proceed with the existing 3scale Istio adapter docs for the SM 2.1 release. Cheers.

There is no 3scale Istio Adapter on the 2.1 release, so no docs about it either. I think what @JStickler means is that the adapter docs should remain for people working with previous releases, Service Mesh 2.0 and below.

Thanks Alex. Makes sense. Cheers.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 13, 2021
@dfennessy dfennessy force-pushed the THREESCALE-7497 branch 3 times, most recently from a4e93e0 to 6af2a84 Compare September 13, 2021 14:25
@JStickler JStickler self-requested a review September 14, 2021 01:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2021
JStickler
JStickler reviewed Sep 14, 2021
View reviewed changes
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments on what you've already got here. I'll keep checking on your PR as you update.

service_mesh/v2x/ossm-threescale-webassembly-module.adoc Outdated Show resolved Hide resolved
service_mesh/v2x/ossm-threescale-webassembly-module.adoc Outdated Show resolved Hide resolved
service_mesh/v2x/ossm-threescale-webassembly-module.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2021
@dfennessy dfennessy force-pushed the THREESCALE-7497 branch 4 times, most recently from eddd3d4 to c0f1d79 Compare September 24, 2021 15:43
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 10, 2021
@dfennessy
Copy link
Contributor Author

Thanks @adellape

Updates made and awaiting your sign off 🙂

@adellape adellape added this to the Next Release milestone Nov 11, 2021
@abrennan89 abrennan89 merged commit 3b65bc3 into openshift:main Nov 11, 2021
@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.6

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.7

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.8

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.9

@abrennan89
Copy link
Contributor

/cherrypick enterprise-4.10

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38620

In response to this:

/cherrypick enterprise-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38621

In response to this:

/cherrypick enterprise-4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38622

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38623

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 11, 2021
Merged
@openshift-cherrypick-robot
Copy link

@abrennan89: new pull request created: #38624

In response to this:

/cherrypick enterprise-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulanand16nov rahulanand16nov rahulanand16nov approved these changes

@abrennan89 abrennan89 abrennan89 left review comments

@porueesq porueesq porueesq requested changes

@adellape adellape adellape approved these changes

@pehala pehala pehala approved these changes

@JStickler JStickler Awaiting requested review from JStickler

Assignees
No one assigned
Labels
branch/enterprise-4.6 branch/enterprise-4.7 branch/enterprise-4.8 branch/enterprise-4.9 branch/enterprise-4.10 peer-review-done Signifies that the peer review team has reviewed this PR service-mesh Label for all Service Mesh PRs size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Next Release
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@dfennessy @JStickler @unleashed @rahulanand16nov @pehala @abrennan89 @openshift-cherrypick-robot @adellape @porueesq