-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[WIP] OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature #36751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature #36751
Conversation
✔️ Deploy Preview for osdocs ready! 🔨 Explore the source changes: 579536f 🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/62250ca8bcd7620007cc681c 😎 Browse the preview: https://deploy-preview-36751--osdocs.netlify.app |
63c9b33
to
2829033
Compare
2829033
to
9b9f5c3
Compare
8fdd468
to
6c22e72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some suggestions and style/formatting requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<.> Set the directory where you want to store your test results, such as `test-results`. | |
<.> Set the location of the directory to store your test results, such as `test-results`. |
Does this directory have to exist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, I'd rewrite this whole thing without the broken flag and be like "this command store the test results in the test-output
directory of your working directory." When the bug is fixed, update the docs to describe the flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 The way this is written makes this read as if 'we have this cool new feature, but none of it works - good luck'.
I wouldn't document this till the bug was/is fixed; only document the way's in which it properly works.
a6f78b6
to
101b247
Compare
Release: 4.9 OSDOCS-2210 Docs preview: Related release note:
101b247
to
579536f
Compare
In preparation for OCP 4.10 GA, I'm moving the Milestone to "Next Release" as this PR did not make the merge by the 4.10 GA date. Post-GA, any open 4.10 PRs fall under the "Next Release" bucket in the same way that 4.6-4.9 PRs are already there. This change does not have any impact on the work in this PR; it's a housekeeping task to keep account of all PRs that had already merged by the 4.10 GA date. 😁 |
The This is because your PR targets the If the update in your PR does NOT apply to version 4.11 onward, please retarget this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
The enterprise-4.12 label has been added to this PR. This is because your PR targets the If the update in your PR does NOT apply to version 4.12 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main. |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Release: 4.10
OSDOCS-2210
Docs preview: https://deploy-preview-36751--osdocs.netlify.app/openshift-enterprise/latest/operators/operator_sdk/osdk-scorecard#osdk-scorecard-store-output_osdk-scorecard