Skip to content

Conversation

michaelryanpeter
Copy link
Contributor

@michaelryanpeter michaelryanpeter commented Sep 24, 2021

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 24, 2021
@netlify
Copy link

netlify bot commented Sep 24, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 579536f

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/62250ca8bcd7620007cc681c

😎 Browse the preview: https://deploy-preview-36751--osdocs.netlify.app

@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2210_OSDK-1713_Custom-Scorecard-storage-feature branch 9 times, most recently from 63c9b33 to 2829033 Compare September 27, 2021 20:02
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2210_OSDK-1713_Custom-Scorecard-storage-feature branch from 2829033 to 9b9f5c3 Compare September 29, 2021 18:54
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2021
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2210_OSDK-1713_Custom-Scorecard-storage-feature branch 2 times, most recently from 8fdd468 to 6c22e72 Compare September 29, 2021 21:23
Copy link

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2021
Copy link

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@michaelryanpeter michaelryanpeter changed the title OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature [WIP] OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature Oct 13, 2021
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2021
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 11, 2022
@michaelryanpeter
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 4, 2022
@michaelryanpeter michaelryanpeter added the peer-review-needed Signifies that the peer review team needs to review this PR label Mar 1, 2022
@michaelryanpeter michaelryanpeter changed the title [WIP] OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature Mar 4, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2022
Copy link
Contributor

@kalexand-rh kalexand-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestions and style/formatting requests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<.> Set the directory where you want to store your test results, such as `test-results`.
<.> Set the location of the directory to store your test results, such as `test-results`.

Does this directory have to exist?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I'd rewrite this whole thing without the broken flag and be like "this command store the test results in the test-output directory of your working directory." When the bug is fixed, update the docs to describe the flag.

Copy link
Contributor

@sferich888 sferich888 Mar 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 The way this is written makes this read as if 'we have this cool new feature, but none of it works - good luck'.

I wouldn't document this till the bug was/is fixed; only document the way's in which it properly works.

@kalexand-rh kalexand-rh added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Mar 4, 2022
@kalexand-rh kalexand-rh added this to the Future Release milestone Mar 4, 2022
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2210_OSDK-1713_Custom-Scorecard-storage-feature branch 2 times, most recently from a6f78b6 to 101b247 Compare March 4, 2022 22:01
Release: 4.9

OSDOCS-2210

Docs preview:

Related release note:
@michaelryanpeter michaelryanpeter force-pushed the OSDOCS-2210_OSDK-1713_Custom-Scorecard-storage-feature branch from 101b247 to 579536f Compare March 6, 2022 19:33
@michaelryanpeter michaelryanpeter changed the title OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature [WIP] OSDOCS-2210: OSDK-1713 Custom Scorecard storage feature Mar 7, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 7, 2022
@bobfuru
Copy link
Contributor

bobfuru commented Mar 10, 2022

In preparation for OCP 4.10 GA, I'm moving the Milestone to "Next Release" as this PR did not make the merge by the 4.10 GA date. Post-GA, any open 4.10 PRs fall under the "Next Release" bucket in the same way that 4.6-4.9 PRs are already there. This change does not have any impact on the work in this PR; it's a housekeeping task to keep account of all PRs that had already merged by the 4.10 GA date. 😁

@bergerhoffer
Copy link
Contributor

The branch/enterprise-4.11 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.10. And any PR going into main must also target the latest version branch (enterprise-4.11).

If the update in your PR does NOT apply to version 4.11 onward, please retarget this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 12, 2022
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 12, 2022
@bergerhoffer
Copy link
Contributor

The enterprise-4.12 label has been added to this PR.

This is because your PR targets the main branch and is labeled for enterprise-4.11. And any PR going into main must also target the latest version branch (enterprise-4.12).

If the update in your PR does NOT apply to version 4.12 onward, please re-target this PR to go directly into the appropriate version branch or branches (enterprise-4.x) instead of main.

@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Sep 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michaelryanpeter michaelryanpeter deleted the OSDOCS-2210_OSDK-1713_Custom-Scorecard-storage-feature branch October 26, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.10 branch/enterprise-4.11 branch/enterprise-4.12 do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants