Skip to content

BZ 2009796: IPI BM Dual-stack must use IPv4 as the primary IP family #37424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2021
Merged

BZ 2009796: IPI BM Dual-stack must use IPv4 as the primary IP family #37424

merged 1 commit into from
Oct 13, 2021

Conversation

johnwilkins
Copy link
Contributor

@johnwilkins johnwilkins commented Oct 13, 2021 •
edited
Loading

Edited the module to make the IPv4 requirement prominent and note that IPv6 is not supported as the primary IP family.

See https://bugzilla.redhat.com/show_bug.cgi?id=2009796 for details.

Preview URL: https://deploy-preview-37424--osdocs.netlify.app/openshift-enterprise/latest/installing/installing_bare_metal_ipi/ipi-install-installation-workflow#modifying-install-config-for-dual-stack-network_ipi-install-configuration-files

Releases: 4.8 and 4.9

Signed-off-by: John Wilkins jowilkin@redhat.com

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2021
@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: 6d16c91b8762e0912e742c0ef67befd04ae5a3bd

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/616639606aa13700081696fa

😎 Browse the preview: https://deploy-preview-37424--osdocs.netlify.app

@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: c6a3adc335e30947a40bd03b415a3efa739f11b0

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/6166398c6051c600084a043f

😎 Browse the preview: https://deploy-preview-37424--osdocs.netlify.app

@netlify
Copy link

netlify bot commented Oct 13, 2021 •
edited
Loading

✔️ Deploy Preview for osdocs ready!

🔨 Explore the source changes: cefdefb

🔍 Inspect the deploy log: https://app.netlify.com/sites/osdocs/deploys/61673f0973d69200083839d2

😎 Browse the preview: https://deploy-preview-37424--osdocs.netlify.app

@hardys
Copy link

hardys commented Oct 13, 2021

/lgtm added a small suggestion but not blocking on it :)

@johnwilkins johnwilkins force-pushed the bz-2009796 branch 2 times, most recently from 3cd5763 to 32876e0 Compare October 13, 2021 18:12
@bobfuru bobfuru added this to the Next Release milestone Oct 13, 2021
bobfuru
bobfuru reviewed Oct 13, 2021
View reviewed changes
Copy link
Contributor

@bobfuru bobfuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion but otherwise LGTM!

@bobfuru bobfuru added the peer-review-done Signifies that the peer review team has reviewed this PR label Oct 13, 2021
@johnwilkins
bz-2009796: Edited the module to make the IPv4 requirement prominent …
cefdefb 
…and note that IPv6 is not supported as the primary IP family..
@bobfuru bobfuru merged commit 6322638 into openshift:main Oct 13, 2021
@bobfuru
Copy link
Contributor

bobfuru commented Oct 13, 2021

/cherrypick enterprise-4.8

@bobfuru
Copy link
Contributor

bobfuru commented Oct 13, 2021

/cherrypick enterprise-4.9

@openshift-cherrypick-robot
Copy link

@bobfuru: #37424 failed to apply on top of branch "enterprise-4.8":

Applying: bz-2009796: Edited the module to make the IPv4 requirement prominent and note that IPv6 is not supported as the primary IP family..
Using index info to reconstruct a base tree...
M	installing/installing_bare_metal_ipi/ipi-install-configuration-files.adoc
Falling back to patching base and 3-way merge...
Auto-merging installing/installing_bare_metal_ipi/ipi-install-configuration-files.adoc
CONFLICT (content): Merge conflict in installing/installing_bare_metal_ipi/ipi-install-configuration-files.adoc
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bz-2009796: Edited the module to make the IPv4 requirement prominent and note that IPv6 is not supported as the primary IP family..
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick enterprise-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 13, 2021
Merged
@openshift-cherrypick-robot
Copy link

@bobfuru: new pull request created: #37495

In response to this:

/cherrypick enterprise-4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bobfuru bobfuru mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hardys hardys hardys left review comments

@bobfuru bobfuru bobfuru left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

branch/enterprise-4.8 branch/enterprise-4.9 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

4 participants

@johnwilkins @hardys @bobfuru @openshift-cherrypick-robot